Repository navigation
logger: show version numbers with the ABI mismatch error - #664
Merged
Merged
Conversation
xiulipan
suggested changes
Dec 4, 2018
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Need some update to use macro to parse some readable version info.
Contributor
There was a problem hiding this comment.
@ranj063
why not use SOF_ABI_VERSION_MAJOR(src/include/uapi/abi.h) and other macro to parse a more readable output?
Member
There was a problem hiding this comment.
Best to also include MINOR and PATCH versions and ABI version of ldc file too. That way users can tell if ldc or logger is too old.
Collaborator
Author
There was a problem hiding this comment.
@lgirdwood @xiulipan updated the PR now
Show the version numbers along with the ABI mismatch error. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
xiulipan
approved these changes
Dec 5, 2018
Contributor
|
LGTM |
bkokoszx
approved these changes
Dec 5, 2018
|
We experienced some problems with internal CI platforms but I brought them back to work, rerun build and everything seems to look good. |
Member
|
Thanks @zrombel now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the version numbers along with the ABI mismatch error.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com