Skip to content

logger complains about abi mismatch #662

Closed

Description

@ranj063

While trying to run the logger with the latest SOF master, I see the error:
Error: abi version in sof-apl.ldc file does not coincide with abi version used by logger

Activity

  1. added
    bugSomething isn't working as expected
    GLKApplies to Gemini Lake platform
    on Dec 3, 2018
  2. ranj063 commented on Dec 3, 2018

    @ranj063
    CollaboratorAuthor

    kernel branch: cros-sof-v4.14-rebase
    topology: SOF master (sof-glk-da7219.m4)

  3. lgirdwood commented on Dec 3, 2018

    @lgirdwood
    Member

    @ranj063 is your logger from latest SOF master too (not SOFT repo). Can you also send a PR that prints the ABI versions for logger and ldc files in the error message (that way we can tell what is out of date). Thanks

  4. ranj063 commented on Dec 3, 2018

    @ranj063
    CollaboratorAuthor

    @lgirdwood yes I used SOF master for logger, topology and firmware. I will send the PR

  5. lgirdwood commented on Dec 3, 2018

    @lgirdwood
    Member

    Thanks, btw ABI going through some changes to make all this go away with future ABI updates, hence the failures atm. Some more ABI PRs pending shortly.

  6. ranj063 commented on Dec 3, 2018

    @ranj063
    CollaboratorAuthor

    Updated the error message with version numbers in #664 and the error seen is:
    Error: abi version in sof-apl.ldc file does not coincide with abi version used by logger
    logger ABI Version is 33554432
    ldc_file ABI Version is 1

  7. added
    P1Blocker bugs or important features
    on Dec 4, 2018
  8. mengdonglin commented on Dec 4, 2018

    @mengdonglin
    Collaborator

    Need to monitor
    #663
    #664
    and further kernel update to fix this issue.

  9. stevyan commented on Dec 4, 2018

    @stevyan

    Summary:
    Issue isn't seen both on the APL (pcm512x ) & BYT (rt5651):

    Test Env:
    sof master: b3692cd
    sof tool: b3692cd
    kernel sof-dev: d72b338
    tplg: sof-apl-pcm512x.tplg-b3692cd7, sof-byt-rt5651-b3692cd7.tplg

  10. xiulipan commented on Dec 4, 2018

    @xiulipan
    Contributor

    @stevyan
    Are you sure about the test case?
    I used the latest logger and still see the error. But some older logger have no such issues

    sudo ./sof-logger -l sof-apl.ldc
    Error: abi version in sof-apl.ldc file does not coincide with abi version used by logger.
    
  11. xiulipan commented on Dec 4, 2018

    @xiulipan
    Contributor

    @ranj063
    From you log, it seems we got some wrong ldc abi version.
    33554432 is 0x2000000, thus the SOF_ABI_VERSION_MAJOR is 2.

  12. xiulipan commented on Dec 4, 2018

    @xiulipan
    Contributor

    @bkokoszx @akloniex
    Please check ldc generate functions, it seems the abi_version there is not right.

  13. mengdonglin commented on Dec 4, 2018

    @mengdonglin
    Collaborator

    I cannot see any ABI update for this on kernel sof-dev branch, so this should be a generic issue, not only for GLK.

  14. xiulipan commented on Dec 4, 2018

    @xiulipan
    Contributor

    @stevyan @bkokoszx @akloniex
    Retest with build server binary, no error.
    Confused about why the original bug happen.

  15. bkokoszx commented on Dec 4, 2018

    @bkokoszx
    Collaborator

    @ranj063
    Could you try to rebuild rimage, then SOF and afterwards try to reproduce issue?
    It seems very similar to (I would say it can be the same :)): #642
    ./autogen.sh
    ./configure --enable-rimage
    make
    sudo make install

  16. ranj063 commented on Dec 4, 2018

    @ranj063
    CollaboratorAuthor

    @bkokoszx yes this problem does go away after building rimage.
    I just realized that BUILD_RIMAGE is set to 0 in the xtensa_build_all script.
    I thought we always build rimage before building the FW.

    @xiulipan do you know why we changed this?

  17. xiulipan commented on Dec 5, 2018

    @xiulipan
    Contributor

    @ranj063
    That maybe some old code remaining. I was intend to have some args to set rimage build to speed up CI build and local build. That change is gone somehow, but the flag used for it is still in the scripts.
    Let me have some fix for that.

  18. removed
    APLApplies to Apollolake platform
    on Dec 5, 2018
  19. mengdonglin commented on Dec 5, 2018

    @mengdonglin
    Collaborator

    @xiulipan will rimage building be optional or based on the change of its dependencies?

  20. added
    P2Critical bugs or normal features
    and removed
    P1Blocker bugs or important features
    on Dec 5, 2018
  21. xiulipan commented on Dec 6, 2018

    @xiulipan
    Contributor

    @mengdonglin
    I think we need to make it optional.

  22. lgirdwood commented on Dec 6, 2018

    @lgirdwood
    Member

    @ranj063 I hit this, but it's because the top level Makefile does not recurse into the tools directory to re-make the tools. You need to do this manually.

  23. ranj063 commented on Jan 24, 2019

    @ranj063
    CollaboratorAuthor

    @mengdonglin closing this as the issue is fixed by building rimage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GLKApplies to Gemini Lake platformP2Critical bugs or normal featuresbugSomething isn't working as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions