[mrajwa]

Signed-off-by: Marcin Rajwa marcin.rajwa@linux.intel.com

This change allows to send an IPC request for FW to start GDB session.
NOTE: In order to provide IPC response which includes new feature update of ABI will be required.

[lgirdwood]

Could you also add yourself to CODEOWNERS for GDB related files. Thanks !

[lgirdwood]

C style comments please.

[mrajwa]

Corrected.

[zrombel]

CI test will fail because of changes in sof_ipc_fw_ready structure. We will test it manually and give feedback. PR merge have to be synchronized with CI Tests update.

[lgirdwood]

@zrombel @xiulipan given that you guys are doing the CI dev, does it make sense to add you guys to any part of the CODEOWNERS so you are notified on any areas that could impact CI ?

[lgirdwood]

@mrajwa ping, update ready yet ?

[mrajwa]

@lgirdwood , updated now.

[zrombel]

@lgirdwood that's actually a good idea. As for CI tests we are mainly concerned about IPC structures which changes will affect tests execution.

[zrombel]

All tests have pass and we are ready with test update so merge whenever you're ready.

[xiulipan]

@lgirdwood @zrombel
I think for ABI change may need notify CI. For QB, they may need modify their IPC structure for sof-ci the kernel need to be updated as well.

[lgirdwood]

@mrajwa thanks, btw there's a small conflict in CODEOWNERS. Will merge after fixed.

[mrajwa]

@lgirdwood, conflict in CODEOWNERS resolved.

[lgirdwood]

@mrajwa are you sure, I waited a few hours and double checked but it still shows a conflict for me ?

[mrajwa]

@lgirdwood, how about now?

[lgirdwood]

@mrajwa got it now, it did disappear from github for a few hours though but it's merged now.

[xiulipan]

@mrajwa @lgirdwood
Where is the linux kernel part for this ABI change? And where is the ABI version change?

Why not use

	uint32_t gdb_enabled;
 	/* reserved for future use */
	uint32_t reserved[3];

There are 4 uint32_t reserved for the future use. Just change the whole IPC structure size will have a sudden shock for the linux and sof.

[lgirdwood]

@xiulipan no users yet, so ABI part can updated once kernel part is merged (otherwise we increment ABI for no benefit|).