Repository navigation
topology1: re-add support for HDAudio+ 2ch DMIC-PDM1 configurations - #5992
Merged
Merged
Conversation
There are multiple cases where we cannot detect that PDM1 is used instead of the default PDM0. BugLink: thesofproject#5989 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Generate 2 files for 1 and 2ch cases. These topologies can be used by setting options snd-sof-pci tplg_filename=<file> in /etc/modprobe.d/alsa-base.conf BugLink: thesofproject#5989 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
aborisovich,
dbaluta,
lbetlej,
lgirdwood,
marc-hb and
mmaka1
as code owners
July 6, 2022 19:18
lgirdwood
approved these changes
Jul 6, 2022
marc-hb
removed their request for review
July 7, 2022 00:21
aiChaoSONG
approved these changes
Jul 7, 2022
aiChaoSONG
left a comment
aiChaoSONG
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but a simple question not related to this PR, but related to DMIC:
- For the 1ch topology, why do we still need to set -DCHANNELS=2? what limitations do we have that stop us to set -DCHANNELS=1?
Member
Author
@aiChaoSONG the DMIC spec is by design based on 2 channels. The left microphone uses the clock-high phase to transmit its data on the shared data line and the right microphone uses the clock-low phase. So even if you have a single mic, you will still need to deal with the two phases. The other point is that I don't think any of the pipelines support mono streams, so we have to duplicate the single channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update of PR #3847 which was never merged.
There are additional platforms released with the PDM1 issue so we have to officially support those topologies.
Companion PR to avoid file overrides and use kernel parameter to select these topologies : thesofproject/linux#3740
Tested by @ewfuentes
BugLink: #5989