Repository navigation
Simplifications for codec_adapter_set_params() - #5160
Merged
Merged
Conversation
ranj063
requested review from
cujomalainey,
dbaluta,
lbetlej,
lgirdwood,
marc-hb,
mmaka1,
mrajwa and
plbossart
as code owners
January 6, 2022 18:35
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 6, 2022 18:37
e7c0573 to
1e87728
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
right that was a mistake |
marc-hb
removed their request for review
January 6, 2022 18:55
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 6, 2022 19:55
1e87728 to
c70f860
Compare
lgirdwood
previously approved these changes
Jan 6, 2022
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 6, 2022 22:45
c70f860 to
1dd7fb9
Compare
cujomalainey
previously approved these changes
Jan 6, 2022
cujomalainey
left a comment
cujomalainey
left a comment
Contributor
There was a problem hiding this comment.
much appreciated thank you!
Collaborator
Author
|
@lgirdwood I think #5166 should go first and then I can rebase this one |
dbaluta
previously approved these changes
Jan 8, 2022
Collaborator
|
Looks good to me. Somehow, I missed to add my review. |
lyakh
previously approved these changes
Jan 10, 2022
Collaborator
There was a problem hiding this comment.
I didn't fully verify this, but I guess it's a correct way to merge the above two cases and an additional call to codec_load_config() isn't needed because it's already called inside load_setup_config()
Collaborator
Author
There was a problem hiding this comment.
@lyakh looking more into this I realized that I could drop load_setup_config() altogether and modify module_load_config() to handle both runtime and setup configs. Updated accordingly.
It can be accessed via cdata in the function. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Remove the goto's and return the appropriate values to simplify the codec_adapter_set_params() function. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Remove the unnecessary braces in codec_adapter_set_params(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Check if more fragments of config data are expected first and return immediately to make the code easier to follow. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 10, 2022 17:10
1dd7fb9 to
2b6a947
Compare
ranj063
dismissed stale reviews from lyakh, dbaluta, cujomalainey, and lgirdwood
January 10, 2022 17:12
Additional patch added
cujomalainey
approved these changes
Jan 10, 2022
lgirdwood
approved these changes
Jan 10, 2022
Member
|
@dbaluta good for you ? |
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 11, 2022 05:29
2b6a947 to
c5c0332
Compare
lyakh
requested changes
Jan 11, 2022
Modify module_load_config() to handle both setup and runtime configs and remove load_setup_config(). Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/codec_adapter
branch
from
January 11, 2022 16:04
c5c0332 to
2d39351
Compare
lyakh
approved these changes
Jan 11, 2022
dbaluta
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.