Repository navigation
Revert "topology: redirection to workaround hardcoded alsatplg permissions" - #5132
Merged
Merged
Conversation
…sions" This reverts commit eb34437. Fixes thesofproject#5113 The `alsatplg -o -` feature is incompatible with `-v` and basically buggy because it happily sends .tplg output and debug statements to the same place without a care. To reproduce the bug, simply run: VERBOSE=1 ./scripts/build-tools.sh -T ... then observe .tplg output files like this: B0x003d3b/015675 - pcm 'DMIC': write 912 bytes B0x0040cb/016587 - pcm 'HDMI1': write 912 bytes B0x00445b/017499 - pcm 'HDMI2': write 912 bytes B0x0047eb/018411 - pcm 'HDMI3': write 912 bytes B0x004b7b/019323 - pcm 'DMIC16kHz': write 912 bytes B0x004f0b/020235 - block size for type be (11:10) is 0x2ad4/10964 B0x004f0b/020235 - header index 0CoSA^E^@^@^@^@^@^@^@^H^@^@^@$^@^@ ^@^@^@^@^@s^@^@^@^@^@^@^@^A^@^@^@p^@^@^@ ^@^@^@.^@^@^@ ^@^@^@^F^@^ @^@^F^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^ @^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^ @^@^@^@^@^@^@^@^@^... Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
December 24, 2021 08:35
This was referenced Dec 24, 2021
ranj063
approved these changes
Dec 24, 2021
lgirdwood
approved these changes
Dec 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit eb34437.
Fixes #5113
The
alsatplg -o -feature is incompatible with-vand basicallybuggy because it happily sends .tplg output and debug statements to
the same place without a care. To reproduce the bug, simply run:
... then observe .tplg output files like this:
Signed-off-by: Marc Herbert marc.herbert@intel.com