Skip to content

Workaround for alsatplg hardcoded permissions - #5072

Merged
lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:alsatplg-ro
Dec 14, 2021
Merged

lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:alsatplg-ro

Conversation

@marc-hb

@marc-hb marc-hb commented Dec 11, 2021 •

Copy link
Copy Markdown
Collaborator

Workaround for bug alsa-project/alsa-utils#126

DRAFT until dependency and bug fix #5071 is merged, must be rebased on top of #5071 Rebased.

@marc-hb

marc-hb commented Dec 11, 2021 •

Copy link
Copy Markdown
Collaborator Author

sof-ci/jenkins is down this weekend, will have to SOFCI TEST on Monday. Everything else is 100% green.

@marc-hb

marc-hb commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator Author

CML not available in https://sof-ci.01.org/sofpr/PR5072/build11350/devicetest/, everything else green.

@lgirdwood

Copy link
Copy Markdown
Member

@marc-hb this looks like it contains the same topology build move patch as your other PR ? #5071 is merged.

Less copy/paste/diverge => more maintenance.

Zero visible change, pure copy/paste reduction.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Use a redirection to work around hardcoded alsatplg permissions.
See bug alsa-project/alsa-utils#126

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb changed the title [DRAFT] Workaround for alsatplg hardcoded permissions Workaround for alsatplg hardcoded permissions Dec 13, 2021
@marc-hb
marc-hb marked this pull request as ready for review December 13, 2021 15:32
@marc-hb

marc-hb commented Dec 13, 2021 •

Copy link
Copy Markdown
Collaborator Author

@marc-hb this looks like it contains the same topology build move patch as your other PR ? #5071 is merged.

Yes, rebased now. Please don't look at drafts :-)

Only 14 non-drafts without review right now:
https://github.com/thesofproject/sof/pulls?q=is%3Apr+is%3Aopen+review%3Anone+isdraft%3Afalse

@marc-hb

marc-hb commented Dec 13, 2021 •

Copy link
Copy Markdown
Collaborator Author

https://sof-ci.01.org/sofpr/PR5072/build11359/devicetest is amazingly all green.

qemu-boot-test is failing on some platforms in https://github.com/thesofproject/sof/runs/4508240036?check_suite_focus=true which is very new and very worrying but completely unrelated to a topology build fix.

EDIT: next attempt is green https://github.com/thesofproject/sof/actions/runs/1573610053 , no idea why :-(

timeout --foreground 2.0 /home/sof/qemu/xtensa-softmmu/qemu-system-xtensa -cpu cannonlake -M adsp_cnl -nographic -kernel /home/sof/sof.git/build_cnl_gcc/src/arch/xtensa/sof-cnl.ri -rom /home/sof/sof.git/build_cnl_gcc/src/arch/xtensa/rom-cnl.bin
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9

68000 times!

bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
bridge-io: msg send failed -9
qemu-system-xtensa: terminating on signal 15 from pid 20 (timeout)
bridge-io: msg send failed -9
Error ipc reg failed
Error boot failed
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68516 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68517 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68518 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68519 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68520 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68521 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68522 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68523 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68524 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68525 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68526 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68527 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68528 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68529 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68530 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68531 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68532 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68533 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68534 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68535 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68536 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68537 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68538 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68539 type 2 msg 64 size 16 ret -1
irq: send busy interrupt 0x8dead000
bridge-io: msg send: 68540 type 2 msg 64 size 16 ret -1
Error: Process completed with exit code 2.

@lgirdwood
lgirdwood merged commit eb34437 into thesofproject:main Dec 14, 2021
@marc-hb
marc-hb deleted the alsatplg-ro branch December 20, 2021 07:37
@marc-hb

marc-hb commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator Author

Note there has never been any permission issue when using make -C installer because it uses install -D -p -m 0664

@marc-hb

marc-hb commented Dec 20, 2021

Copy link
Copy Markdown
Collaborator Author

A heads-up that @ranj063 has been experiencing an extremely weird .tplg file corruption that is solved by reverting this commit, see bug #5113

We don't plan on doing anything yet because CI has been perfectly happy with this commit for 6 days, I cannot reproduce and no one else has complained either but please keep an eye on any .tplg issues and share any detail in #5113 if relevant.

@marc-hb

marc-hb commented Dec 24, 2021

Copy link
Copy Markdown
Collaborator Author

Revert submitted in #5132 :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants