Repository navigation
2 pipeline fixes - #4868
Merged
Merged
2 pipeline fixes#4868
Conversation
pipeline_for_each_comp() and buffer_set_params() can fail, make sure to check their return values and propagate any errors. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 13, 2021 12:02
ranj063
reviewed
Oct 13, 2021
Collaborator
There was a problem hiding this comment.
@lyakh while we're doing this,c an we also change all the callers of pipeline_for_each_comp() to return the error There are at least a couple of places where we simply ignore the return value
Member
There was a problem hiding this comment.
This can be an new PR though.
lgirdwood
approved these changes
Oct 14, 2021
Member
|
@lyakh can you check CI. |
Collaborator
Author
@lgirdwood yes, I'm checking it. Looks like some flows depend on the current behaviour. Not sure about the APL-nocodec failures, but QB might indicate, that they expect to continue recursing past mixers / muxers ignoring stop requests. |
When recursing pipeline components, using pipeline_for_each_comp(), each component's .comp_func() method is called. Those methods can return 0 for success, a negative error code or PPL_STATUS_PATH_STOP if recursing should stop. However, the latter code is ignored by pipeline_for_each_comp(). Add a check for that code and terminate recursion if detected. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
force-pushed
the
20211008-misc_2
branch
from
October 15, 2021 10:41
d85b99e to
9eab81d
Compare
Collaborator
Author
|
CI: a single unrelated error: |
lgirdwood
approved these changes
Oct 15, 2021
Member
|
BYT IPC flood look like network error, APL showing the known suspend error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.