You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] pipeline_comp_trigger() has a logic error #4746
Also note, that pipeline_for_each_comp() ignores non-negative return codes from the iterator function:
int err = ctx->comp_func(buffer_comp, buffer,
ctx, dir);
return 0;
This means, that if pipeline_comp_trigger() returns PPL_STATUS_PATH_STOP for the first component in the pipeline, i.e. when directly called from pipeline_trigger_run(), that return code will be propagated back to the caller. However, if that code is returned by one of later pipeline components, it will be ignored. This is probably not the intended behaviour. Note, that this code has been significantly altered by my recent commits, e.g. e8d2226 but this behaviour has been preserved and can be verified in the code base before that commit.
Activity
lgirdwood commentedon Sep 10, 2021
@lyakh - not intended behavior - we should respect the result and STOP. Can you fix ?
lyakh commentedon Nov 16, 2021
fixed by #4868