Skip to content

Fix deep buffer playback pipelines for cavs - #4534

Merged
lgirdwood merged 4 commits into
thesofproject:mainfrom
ranj063:fix/cavs_deepbuffer
Jul 23, 2021
Merged

lgirdwood merged 4 commits into
thesofproject:mainfrom
ranj063:fix/cavs_deepbuffer

Conversation

@ranj063

@ranj063 ranj063 commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

APL cannot support 2 deep buffer playback PCM's. So fix this by adding only 1deep buffer playback PCM on SSP5 for APL and SSP0 for the rest

ranj063 added 2 commits July 22, 2021 11:14
This reverts commit 6516a8c.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
…SP2"

This reverts commit a10b5dc.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063

ranj063 commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator Author

fixes #4526

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we can simplify by keeping the structure identical instead of special casing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why special-case? it'd be fine to use a mixer on all 3 dai pipelines, and only connect a second host pipeline for one of the mixers.
That way all 3 playback path have the same latency/processing/settings.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would also make the pipeline management less complicated with fewer options.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plbossart fixed now. here's how the tplg's look now
APL:
tplg
Rest:
tplg

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just what the doctor ordered. Thanks Ranjani.

ranj063 added 2 commits July 22, 2021 12:14
…based pipelines

Convert all playback pipelines to have a mixer so adding a deep-buffer
pipeline will be simpler.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
on SSP5 for BXT and SSP0 for all others.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
ranj063 force-pushed the fix/cavs_deepbuffer branch from 319952a to c4af135 Compare July 22, 2021 19:41

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ranj063
The daily tests start in 6mn, probably too late to merge but can we start a daily test later this evening with this PR, so that we can merge with confidence tomorrow before the week-end?

@ranj063

ranj063 commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator Author

LGTM @ranj063
The daily tests start in 6mn, probably too late to merge but can we start a daily test later this evening with this PR, so that we can merge with confidence tomorrow before the week-end?

Yes, will do!

@lgirdwood
lgirdwood merged commit 764a065 into thesofproject:main Jul 23, 2021
@ranj063
ranj063 deleted the fix/cavs_deepbuffer branch November 1, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants