Skip to content

Revert(s) to fix APL nocodec support - #4532

Closed
plbossart wants to merge 1 commit into
thesofproject:mainfrom
plbossart:fix/apl-nocodec
Closed

Revert(s) to fix APL nocodec support#4532
plbossart wants to merge 1 commit into
thesofproject:mainfrom
plbossart:fix/apl-nocodec

Conversation

@plbossart

@plbossart plbossart commented Jul 22, 2021

Copy link
Copy Markdown
Member

recent commits broke APL_NOCODEC CI, revert all of them blindly to restore functionality

@plbossart
Revert "topology1: sof-cavs-nocodec: Add the deep buffer PCMs"
8a7267f 
This reverts commit 6516a8c.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
plbossart requested review from keyonjie and ranj063 July 22, 2021 15:53
@plbossart plbossart mentioned this pull request Jul 22, 2021
Closed
@lgirdwood

lgirdwood commented Jul 22, 2021

Copy link
Copy Markdown
Member

recent commits broke APL_NOCODEC CI, revert all of them blindly to restore functionality

What's the repo rate, I've just merged 3 PRs from today with 100% passes in CI.

@ranj063

ranj063 commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

What's the repo rate, I've just merged 3 PRs from today with 100% passes in CI.

100% Liam. My suspicion is on the commit that adds the deep buffer PCMs for the nocodec topology. Let me submit a PR to remove those for APL

@marc-hb

marc-hb commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

Quoting #4526

we dont run multiple-pipeline-all test in the device test for PRs. thats why

@plbossart

plbossart commented Jul 22, 2021

Copy link
Copy Markdown
Member Author

Quoting #4526

we dont run multiple-pipeline-all test in the device test for PRs. thats why

D'oh. that's crazy. these tests fail immediately when there's a problem, not sure why they were filtered out.

@plbossart

plbossart commented Jul 22, 2021

Copy link
Copy Markdown
Member Author

My local tests can narrow the issue to one patch

Revert "topology1: sof-cavs-nocodec: Add the deep buffer PCMs"

The deep buffer PCM never worked for this test it seems.

@marc-hb
marc-hb requested a review from fredoh9 July 22, 2021 16:59
@marc-hb marc-hb changed the title Fix APL nocodec support Reverts to fix APL nocodec support Jul 22, 2021
@marc-hb marc-hb changed the title Reverts to fix APL nocodec support Revert(s) to fix APL nocodec support Jul 22, 2021
@ranj063

ranj063 commented Jul 22, 2021

Copy link
Copy Markdown
Collaborator

@plbossart replacement for this one in #4534

@plbossart plbossart closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta Awaiting requested review from dbaluta
@lbetlej lbetlej Awaiting requested review from lbetlej
@lgirdwood lgirdwood Awaiting requested review from lgirdwood
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@singalsu singalsu Awaiting requested review from singalsu
@keyonjie keyonjie Awaiting requested review from keyonjie
@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner
@fredoh9 fredoh9 Awaiting requested review from fredoh9

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plbossart @lgirdwood @ranj063 @marc-hb