Skip to content

[SKIP CI] zephyr/docker-build.sh: remove apt update / install libssl-dev #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 2 commits into from
May 13, 2021
Merged

[SKIP CI] zephyr/docker-build.sh: remove apt update / install libssl-dev #4182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e39eca
zephyr/docker-build.sh: remove apt update / install libssl-dev
marc-hb May 12, 2021
f4805f9
.github: switch docker image from ':latest' to ':v0.17.3'
marc-hb May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/zephyr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:

- name: build
run: docker run -v "$(pwd)":/workdir
docker.io/zephyrprojectrtos/zephyr-build:latest
docker.io/zephyrprojectrtos/zephyr-build:v0.17.3

@fredoh9 fredoh9 May 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set the version, we need to update occasionally if docker image is updated.
It looks like zephyr's latest image is not stable. Why is so? Can they keep different tag until it get stabilized?

@marc-hb marc-hb May 12, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good question. I've asked the image maintainers on the #infrastructure channel athttps://zephyrproject.slack.com/archives/CGNR3LCHM about a more :stable version but there is none.

Quoting the same channel:

right now we might have a few updates as we are catching up after we merged the 2 dockers, but usually it should be less frequent

I believe we will NOT have to update for every single image release. For now this is just a build test so if it builds with a non-latest image then it is good enough and if it breaks then we update the image (hence the Zephyr SDK) "on-demand". We don't want to force developers to constantly update their toolchain either after all.

We already build Zephyr with the random, latest Zephyr commit of the day so maybe it's good to have one less moving part, should help point the finger when something outside of SOF breaks this.

./zephyr/docker-build.sh
6 changes: 0 additions & 6 deletions zephyr/docker-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,8 @@
set -e
set -x

# export http_proxy=...
# export https_proxy=...

unset ZEPHYR_BASE

sudo --preserve-env=http_proxy,https_proxy apt-get update
sudo --preserve-env=http_proxy,https_proxy apt-get -y install libssl-dev

# Make sure we're in the right place; chgrp -R below.
test -e ./scripts/xtensa-build-zephyr.sh

Expand Down