Repository navigation
[SKIP CI] zephyr/docker-build.sh: remove apt update / install libssl-dev - #4182
Conversation
The Zephyr image has been updated in zephyrproject-rtos/docker-image#58 This will save some time and even better avoid llvm.org glitches like this one: https://github.com/thesofproject/sof/pull/4089/checks?check_run_id=2554961695 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Even though "latest" is being referenced by the current https://github.com/zephyrproject-rtos/docker-image/tree/072880b3#readme I've been told it's too "bleeding edge" to be used in CI. v0.17.3 also has libssl-dev which was the only thing we were missing. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
In https://github.com/thesofproject/sof/pull/4182/checks?check_run_id=2569292327 checkpatch complains that the URL in a commit message is too long. No other checkpatch warning. This is a pure .github actions change so any other, non-github error can be ignored. |
| - name: build | ||
| run: docker run -v "$(pwd)":/workdir | ||
| docker.io/zephyrprojectrtos/zephyr-build:latest | ||
| docker.io/zephyrprojectrtos/zephyr-build:v0.17.3 |
There was a problem hiding this comment.
If we set the version, we need to update occasionally if docker image is updated.
It looks like zephyr's latest image is not stable. Why is so? Can they keep different tag until it get stabilized?
There was a problem hiding this comment.
Very good question. I've asked the image maintainers on the #infrastructure channel athttps://zephyrproject.slack.com/archives/CGNR3LCHM about a more :stable version but there is none.
Quoting the same channel:
right now we might have a few updates as we are catching up after we merged the 2 dockers, but usually it should be less frequent
I believe we will NOT have to update for every single image release. For now this is just a build test so if it builds with a non-latest image then it is good enough and if it breaks then we update the image (hence the Zephyr SDK) "on-demand". We don't want to force developers to constantly update their toolchain either after all.
We already build Zephyr with the random, latest Zephyr commit of the day so maybe it's good to have one less moving part, should help point the finger when something outside of SOF breaks this.
fredoh9
left a comment
fredoh9
left a comment
There was a problem hiding this comment.
Looks good, thank you for the clarification
2 commits. Main one:
zephyr/docker-build.sh: remove apt update / install libssl-dev
The Zephyr image has been updated in
zephyrproject-rtos/docker-image#58
This will save some time and even better avoid llvm.org
glitches like this one:
https://github.com/thesofproject/sof/pull/4089/checks?check_run_id=2554961695