Skip to content

topology: sdw: Update echo ref channel number on max98373 #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Oct 20, 2020
Merged

topology: sdw: Update echo ref channel number on max98373 #3528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/topology/sof-tgl-sdw-max98373-rt5682.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ define(`SMART_RX_CHANNELS', 4)
define(`SMART_FB_CHANNELS', 4)
# Ref capture related
define(`SMART_REF_PPL_ID', 4)
define(`SMART_REF_CH_NUM', 4)
define(`SMART_REF_CH_NUM', 2)

@plbossart plbossart Oct 16, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a longer commit message would be appreciated, what exactly is this 'ref_ch_num'. You have 2 amps, is this one echo reference channel per amp?

@yongzhi1 yongzhi1 Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's my understanding based on the discussion of #3409.
As a result, voltage data only appears on 2xch not 4, will update the commit message.

# PCM related
define(`SMART_PCM_ID', 2)
define(`SMART_PCM_NAME', `smart373-spk')
Expand Down