Repository navigation
topology: sdw: Update echo ref channel number on max98373 - #3528
Merged
Merged
Conversation
plbossart
requested changes
Oct 16, 2020
Member
There was a problem hiding this comment.
a longer commit message would be appreciated, what exactly is this 'ref_ch_num'. You have 2 amps, is this one echo reference channel per amp?
Contributor
Author
There was a problem hiding this comment.
Yes, that's my understanding based on the discussion of #3409.
As a result, voltage data only appears on 2xch not 4, will update the commit message.
Contributor
Author
|
In the same way as of #3421, thanks!! |
The topology has two speaker amp configured, with voltage info feedback-ed to host for each channel in the EchoRef, so update SMART_REF_CH_NUM accordingly. Signed-off-by: Yong Zhi <yong.zhi@intel.com>
lgirdwood
approved these changes
Oct 19, 2020
yongzhi1
marked this pull request as draft
October 19, 2020 15:27
plbossart
approved these changes
Oct 19, 2020
yongzhi1
marked this pull request as ready for review
October 20, 2020 05:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SMART_REF_CH_NUM to 2 based on the hw config.
Signed-off-by: Yong Zhi yong.zhi@intel.com