Repository navigation
pipeline: fix logs in pipeline_comp_params_neg() - #3464
Merged
lgirdwood merged 1 commit intoSep 25, 2020
Merged
Conversation
bkokoszx
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 24, 2020 12:41
Use current->pipeline instead of ppl_data->p as a pipe_dbg() and pipe_err() arguments. ppl_data->p is not set at that point and can cause unexpected errors. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
fix-pipeline_comp_params_neg_logs
branch
from
September 24, 2020 13:31
9673cf2 to
7a36abb
Compare
dbaluta
approved these changes
Sep 24, 2020
keyonjie
approved these changes
Sep 24, 2020
keyonjie
left a comment
keyonjie
left a comment
Contributor
There was a problem hiding this comment.
Thanks Bartosz for spotting this.
Contributor
|
@lgirdwood worth to get this to 1.6 also. |
Member
|
@keyonjie too late for rc1, but yet for v1.6 final. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use current->pipeline instead of ppl_data->p as a
pipe_dbg() and pipe_err() arguments. ppl_data->p
is not set at that point and can cause unexpected
errors.
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com