Repository navigation
trace: verify argument size - #3393
Merged
Merged
Conversation
This functionality counldn't handle empty __VA_ARGS__. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
SOF tracing can only handle up to 32-bit long values, attempts to trace 64-bit values produce unpredictable results. Fix such cases by making sure values are within range and casting them to 32 bits. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
ktrzcinx
force-pushed
the
trace-arg-check
branch
from
September 7, 2020 13:46
d310cfa to
50e239f
Compare
ktrzcinx
force-pushed
the
trace-arg-check
branch
from
September 7, 2020 14:10
50e239f to
7608f24
Compare
lyakh
reviewed
Sep 8, 2020
ktrzcinx
changed the title
paulstelian97
self-requested a review
September 9, 2020 11:06
ktrzcinx
force-pushed
the
trace-arg-check
branch
from
September 10, 2020 04:48
7608f24 to
f26aa46
Compare
lyakh
approved these changes
Sep 10, 2020
lyakh
left a comment
lyakh
left a comment
Collaborator
There was a problem hiding this comment.
comments are optional. Thanks for the improvements!
Collaborator
There was a problem hiding this comment.
I guess we could then remove _META_REQRS_1024()..._META_REQRS_16() but that doesn't have to go with this PR. Looks like _META_DEFER_N() and META_DEFER() are unused too , maybe some other "magic" macros too.
Member
Author
There was a problem hiding this comment.
I guess we could then remove _META_REQRS_1024()..._META_REQRS_16() but that doesn't have to go with this PR.
I add it to commit with META_RECURSE depth reduction, because it's a point from which those are unused.
Trace system support arguments no larger that uint32_t, so this condition should be checked for each trace. Create separate CT_ASSERT, because of need to have multiple instances of assertions with the same error message, what is not possible for STATIC_ASSERT. STATIC_ASSERT has better message printing, so it's not replaced by new version. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
The PP_NARG() macro can only handle integer type arguments, use META_COUNT_VARAGS_BEFORE_COMPILE() instead to avoid having to cast pointer types to integers. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
ktrzcinx
force-pushed
the
trace-arg-check
branch
2 times, most recently
from
September 10, 2020 06:21
7c8f9f2 to
90e71b0
Compare
paulstelian97
approved these changes
Sep 10, 2020
Member
|
@ktrzcinx can you check CI. |
lgirdwood
approved these changes
Sep 10, 2020
There is any user in source code who need deeper recursion level, reducing it allow to prevent compiler error message flood during working with META_RECURSE clients (eg. trace system). Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
trace-arg-check
branch
from
September 10, 2020 15:52
90e71b0 to
47eb6c7
Compare
Member
|
@ktrzcinx can you fix this one, everything else is good to go. |
Member
Author
|
@lgirdwood it won't work without this semicolon. It's because mapping function doesn't add it, to allow usage different separators, like |
Member
|
@ktrzcinx ok, got you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #3376.
Here META_MAP functionality has been used, so it's more flexible solution in case of
_TRACE_EVENT_MAX_ARGUMENT_COUNTchange.