Repository navigation
topology: invoke with m4 --fatal-warnings - #2955
Merged
Merged
Conversation
marc-hb
marked this pull request as ready for review
May 20, 2020 00:30
Collaborator
Author
|
The only Travis failure is the following one which is great because the purpose of this patch is exactly to turn that green failure to red. The test is tested. PR #2954 fixes the actual failure. |
Member
|
@zrombel I'm seeing all green boxes on CI build ? are we good ? |
lgirdwood
approved these changes
May 20, 2020
|
Hi @lgirdwood there is a problem with building tools. See attached log. |
Member
|
@zrombel thanks, the fix for that issue has been merged now. Lets rerun. |
|
Build rerun, everything is ok. |
As seen in PR thesofproject#2954, no one ever notices m4 warnings. As PR thesofproject#2954 will remove sof-tgl-rt711-i2s-rt1308-nohdmi.conf and the only m4 warning currently, this is a great opportunity to upgrade m4 warnings to errors. Note neither Travis nor github have the concept of a "warning", they can only report success or failure. This fix can be considered part of the "green failures" family. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Pure rebase after #2954 removal and the error is gone as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in PR #2954, no one ever notices m4 warnings. As PR #2954 will
remove sof-tgl-rt711-i2s-rt1308-nohdmi.conf and the only m4 warning
currently, this is a great opportunity to upgrade m4 warnings to
errors.
Note neither Travis nor github have the concept of a "warning", they can
only report success or failure.
This fix can be considered part of the "green failures" family.
Signed-off-by: Marc Herbert marc.herbert@intel.com