Repository navigation
topology: remove sof-tgl-rt711-i2s-rt1308-nohdmi.conf - #2954
Conversation
No one seems to be using this topology or they would have seen the error below that DMICs are required on this platform. [ 8%] Generating sof-tgl-rt711-i2s-rt1308-nohdmi.conf m4:tools/topology/sof/pipe-volume-capture-16khz.m4:54: bad expression in eval (bad input): 2 * 2 * CHANNELS * 16 m4:tools/topology/sof/pipe-volume-capture-16khz.m4:57: bad expression in eval (bad input): 2 * 2 * CHANNELS * 16 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
This green failure is hard to spot and has been missed for a number of typical reasons:
|
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
I think this CHANNELS warning was introduced less than 2 months ago by @bkokoszx in PR #2506 / commit a716056 tgl: use additional CHANNEL define in rt711 + rts1308 tplg,
The warning can be seen in 2506's https://travis-ci.org/github/thesofproject/sof/jobs/672408553
It's probably better to revert that commit. @bkokoszx ?
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
@plbossart I think this should be a test tplg and no useful now.
@marc-hb The issue can stay in this tplg means no one need this TPLG any more. I think it is OK to remove it as a "fix" for tplg build
juimonen
left a comment
juimonen
left a comment
There was a problem hiding this comment.
yeah just remove the unused ones...
As seen in PR thesofproject#2954, no one ever notices m4 warnings. As PR thesofproject#2954 will remove sof-tgl-rt711-i2s-rt1308-nohdmi.conf and the only m4 warning currently, this is a great opportunity to upgrade m4 warnings to errors. Note neither Travis nor github have the concept of a "warning", they can only report success or failure. This fix can be considered part of the "green failures" family. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
As seen in PR #2954, no one ever notices m4 warnings. As PR #2954 will remove sof-tgl-rt711-i2s-rt1308-nohdmi.conf and the only m4 warning currently, this is a great opportunity to upgrade m4 warnings to errors. Note neither Travis nor github have the concept of a "warning", they can only report success or failure. This fix can be considered part of the "green failures" family. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
No one seems to be using this topology or they would have seen the
error below that DMICs are required on this platform.
[ 8%] Generating sof-tgl-rt711-i2s-rt1308-nohdmi.conf
m4:tools/topology/sof/pipe-volume-capture-16khz.m4:54: bad expression
in eval (bad input): 2 * 2 * CHANNELS * 16
m4:tools/topology/sof/pipe-volume-capture-16khz.m4:57: bad expression
in eval (bad input): 2 * 2 * CHANNELS * 16
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com