Repository navigation
audio stream: Implement XRUN-permitted behaviour - #2745
Merged
Merged
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
dbaluta
reviewed
Apr 8, 2020
Member
Author
|
Travis fails on doxygen due to error in dcblock.h, unrelated to this PR. |
lgirdwood
requested changes
Apr 9, 2020
Member
There was a problem hiding this comment.
I would also deal with the underrun permitted here (next to it's conditional logic) than as the default return case.
Member
There was a problem hiding this comment.
I would also deal with the overrun permitted here (next to it's conditional logic) than as the default return case. Needs comment too
Add underrun_permitted and overrun_permitted fields to audio_stream structure and initialize them with regard to associated buffer config. Add audio_stream_get_avail/free functions, which take above-mentioned fields into account and use them in getter functions within audio_stream.h instead of avail/free fields directly. Signed-off-by: Artur Kloniecki <arturx.kloniecki@linux.intel.com>
Some components used stream.free/avail fields directly. With introduction of audio_stream_get_free/avail getter functions, such usage should be removed. Signed-off-by: Artur Kloniecki <arturx.kloniecki@linux.intel.com>
paulstelian97
approved these changes
Apr 10, 2020
lgirdwood
approved these changes
Apr 10, 2020
mmaka1
approved these changes
Apr 10, 2020
Member
|
Known CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow-up to recently merged PR #2580
underrun_permitted and overrun_permitted fields have been added to audio_stream structure and initialized during buffer instantiation.
audio_stream_get_<free/avail>_<bytes/samples/frames> functions have been added to audio stream interface, and all occurrences of old API usage have been replaced with the new one.