Repository navigation
topology: buffer: Add XRUN flags field to struct sof_ipc_buffer. - #2580
Conversation
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Do you have a similar kernel PR ?
775e8af to
4d9f784
Compare
|
@lgirdwood Kernel PR added: thesofproject/linux#1920 |
akloniex
changed the title
|
@akloniex we need some logic in the IPC handler to deal with old and new version of this structure sent by kernel. |
|
@lgirdwood Since we follow rules of updating ABI as defined near the top of |
3a36b8f to
41b42f9
Compare
|
Minor ABI updated to 15. |
|
Thanks @akloniex , sorry can you put it to ABI 14, there is an unrelated ABI mismatch causing a delay atm so safer to merge into 14 for merge today. |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Folks, the naming is secret inside language, please change. See comment in kernel:
thesofproject/linux#1920 (review)
41b42f9 to
04c8b51
Compare
|
@lgirdwood ABI changed back to 3.14 |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks a lot @akloniex and @lgirdwood !
FW and kernel patches (thesofproject/linux#1920) are now ABI 14 but classifier is still marking this change as ABI 16 (https://github.com/orgs/thesofproject/projects/2), so we need to either reclassify or change the patches.
|
@xiulipan @lgirdwood @kv2019i Can we stop shuffling ABI version reqired for this PR? |
|
@akloniex @lgirdwood Do we already know how exactly these flags will be used? Currently buffers are not responsible for reporting XRUNs, so are we planning to change that also? |
Please hold on - there has been some ABI breakage that @xiulipan has a plan to fix. This will be a matter of a day or two. @tlauda yep, we will need some logic to check this prior to initiating the XRUN. |
04c8b51 to
c09e7af
Compare
There was a problem hiding this comment.
Pls use the following dox format for longer descriptions:
/**
* Overrun will cause ....
*/
#define ....
2 flags have been added for use during buffer instantiation: SOF_BUF_OVERRUN_PERMITTED and SOF_BUF_UNDERRUN_PERMITTED, along with struct sof_ipc_buffer member fields flags and reserved. Flags field is supposed to hold the above-mentioned flags to allow some control over XRUN behaviour, i.e. prevent XRUN on buffers which are allowed to under/overrun by design. Also added reserved field to the structure in case it comes in handy some time in the future. Signed-off-by: Artur Kloniecki <arturx.kloniecki@linux.intel.com>
c09e7af to
47a02f5
Compare
|
@kv2019i I've moved both to 15, is kernel side good for you ? If so we can merge. |
|
@lgirdwood wrote:
Ack, this looks good, I re-requested reviews for the kernel PR but based on previous round, we should be now good. |
|
@kv2019i ok great - will merge once you give us the all clear. |
2 flags have been added for use during buffer instantiation:
SOF_BUF_OVERRUN_PERMITTED and SOF_BUF_UNDERRUN_PERMITTED,
along with struct sof_ipc_buffer member fields flags and reserved.
Flags field is supposed to hold the above-mentioned flags to allow
some control over XRUN behaviour, i.e. prevent XRUN on buffers which
are allowed to under/overrun by design.
Also added reserved field to the structure in case it comes in handy
some time in the future.
Relates to #2478
Signed-off-by: Artur Kloniecki arturx.kloniecki@linux.intel.com