Repository navigation
Topology: Updates to ASRC related topologies - #2367
Merged
lgirdwood merged 3 commits intoFeb 23, 2020
Merged
Conversation
This patch fixes the apply of DAI_PERIODS for playback sink and capture source buffers. Also the comments for components instantiating are fixed to order sink, source as they are in the parameters to avoid confusion. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Since the new sof pcm512x machine driver supports the DMIC backend it's practical to move the ASRC capture pipelines into this topology to avoid need to change into nocodec mode for ASRC capture tests. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The DMIC capture is added to APL ASRC PCM512x topology so this topology can be removed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
@xiulipan Can the UP2 nocodec fails in CI, nearly all of them, be related to removal of topology sof-apl-asrc-dmic.tplg build? I wonder if I should drop the third commit to check. |
ranj063
approved these changes
Feb 11, 2020
lgirdwood
approved these changes
Feb 11, 2020
Member
|
Looks like a CI DUT issue. Rerun CI |
Member
|
SOFCI TEST |
Contributor
|
@lrgirdwo @singalsu It seems more like some DSP timeout issue at PCM hw param |
Member
|
@xiulipan it's also timing out at DAI config too. |
Merged
Collaborator
Author
|
SOFCI TEST |
Member
|
CI looks unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a bug fix for buffers count where I've messed up sink/source buffers order, add of capture-ASRC pipelines to ASRC playback topology, and remove of capture only ASRC topology.