Repository navigation
SRC frame format detect logic fix and topology add for testing capture via SRC - #1947
Conversation
tlauda
left a comment
tlauda
left a comment
There was a problem hiding this comment.
Do you still see FW panic?
Yes, this was a different issue. There's still the panic if I capture from a DAI with lower rate than DAI rate. Capturing from 16 kHz with 16 - 48 kHz works OK. |
There was a problem hiding this comment.
Please update to use SCHEDULE_TIME_DOMAIN_TIMER.
Master branch has been updated in the meantime.
There was a problem hiding this comment.
Please update to use SCHEDULE_TIME_DOMAIN_TIMER.
Master branch has been updated in the meantime.
31e5a86 to
37ead96
Compare
|
SOFCI TEST |
There was a problem hiding this comment.
There's no undefine() for these macros. They are not needed outside this macro so better to do it.
There was a problem hiding this comment.
Done now (undefines add plus minor topology cleanup). I also created separate pipeline building block macros pipe-src-capture.m4 and pipe-src-volume-capture.m4. The latter is more generic with format convert capability. The other ASRC PR has similar pipeline macros.
This patch avoids wrong configuration for PCM format and audio corruption in capture pipelines usage if the pipeline requires format conversion. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The earlier error message was hard to understand and could be mistaken as internal fail. A redundant trace message about block sizes is removed because the block sizes are set in each copy() in current SRC version. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds topology sof-apl-src-dmic.m4 to test capture SRC. The topology instantiates SRCs for 48 -> 8-48 kHz and 16 -> 8-48 kHz capture. The volume component in pipeline handles PCM format conversion from the fixed S32_LE DMIC DAI format. Also the bugs in the earlier non-used pipeline macro are fixed. The macro pipe-src-capture.m4 is renamed to pipe-src-volume-capture.m4 since it contains a volume component. A new macro pipe-src-capture.m4 is created to provide pipeline building block without volume. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
37ead96 to
65fb06e
Compare
This patch set fixes corrupt audio in SRC capture if the pipeline needs to convert PCM format from capture DAI format. Check is added to fail prepare() if pipelines requires SRC to convert between frame formats. The earlier version did not handle correctly 16 bit capture from 32 bit configured DAI. A test topology is added since earlier there was no topology to test capture-SRC.