Repository navigation
[BUG] Pipelines with SRC component work only when converting from lower to higher sampling rates #1632
Description
Describe the bug
Pipelines with SRC component work only when converting from lower to higher sampling rates. For example if playback pipeline with SRC component is created, host side sampling rate is 16kHz and DAI side sampling rate is 48kHz pipeline works as expected. When host side sampling rate is 48kHz and DAI side sampling rate is 16kHz pipe line fail to copy data.
This bug is caused of incorrect propagation of frames_per_sched parameter trough components in pipelines.
PR 842 #842 is resolving this issue and should be included on master branch.
To Reproduce
Create playback pipeline containing SRC component with source sampling rate = 48000 and sink sampling rage 16000.
Reproduction Rate
Always
Found
SOF FW branch: master, commit: 09b416b and earlier.
Activity
tlauda commentedon Oct 2, 2019
@zrombel Please verify with master.
singalsu commentedon Oct 7, 2019
@zrombel @lgirdwood Thanks for reporting, I'll check this.
tlauda commentedon Oct 10, 2019
@singalsu I think it is fixed. There is #842 mentioned in bug description and it's already merged, so I think we're good.
singalsu commentedon Oct 14, 2019
@tlauda I'm having problems to replicate this. I've set up for testing capture SRC pipelines for both 48 kHz and 16 kHz DMIC DAI. Capture 48 -> 48 kHz via SRC works but e.g. 48 -> 16 kHz doesn't. It's maybe the reported issue. Capture for 16 ->16 kHz, 16 -> 32 kHz, works OK.
In module src.c line 589 "params->rate = cd->source_rate;" looks suspicious. I think it should be instead "params->rate = cd->sink_rate;" for any topology. But changing it does not fix the FW crash that I get.
The stack dump suggests that the crash happens at dma_single_chan_domain_set().
tlauda commentedon Oct 14, 2019
@singalsu What is the pipeline and FW commit you are using and getting crash?
singalsu commentedon Oct 14, 2019
I'm using git master fetched today with a custom topology. We don't have in git any capture SRC topologies.
tlauda commentedon Oct 14, 2019
@singalsu Can you describe how does the pipeline look like and what are the params? I would like to reproduce it on my end.
singalsu commentedon Oct 14, 2019
I need to clean up for you a topology to test with. I'll email it tomorrow.
I'm currently using patched bxt pcm512x machine driver to introduce the DMIC BEs. The topology contains one playback SRC and two capture SRCs. To avoid the complexity I'll make a simple nocodec machine driver topology with single SRC capture pipe.
tlauda commentedon Oct 16, 2019
Should be fixed with #1947 and #1952.
singalsu commentedon Oct 16, 2019
@tlauda Thanks! I'll test the combination of those.
singalsu commentedon Oct 16, 2019
Yep, I'm happy to confirm that these both applied fix the SRC related problems!
jdrzaszcz commentedon Oct 18, 2019
Checked on slim driver with master commit (81cc31b) and src component works on playback and capture pipeline. With both conversion from lower to higher sampling rates and higher to lower.