Skip to content

timer: fix return values of platform_timer_set and arch_timer_set #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbaluta merged 1 commit into from
Oct 10, 2019
Merged

timer: fix return values of platform_timer_set and arch_timer_set #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/arch/xtensa/drivers/timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,5 @@ int64_t arch_timer_set(struct timer *timer, uint64_t ticks)
xthal_set_ccompare(timer->id, time);

@dbaluta dbaluta Oct 10, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me. If you have nothing against I would suggest adding the Fixes tag.
Fixes tag is described here:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

It should be something like this:

Fixes: xxxxxxx ("commit subject of the fixed commit")

xxxx - should be around 12 digits of the fixed commit hash.

@tlauda tlauda Oct 10, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbaluta Done. Could you verify whether I've done it correctly?

@paulstelian97 paulstelian97 Oct 10, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlauda Looks good, GH links to the commit itself. Not sure if 12 digits are actually needed on this repo (they may be needed on the Linux one) but I digress.

arch_interrupt_global_enable(flags);
return 0;
return ticks;
}
2 changes: 1 addition & 1 deletion src/drivers/intel/baytrail/timer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ int64_t platform_timer_set(struct timer *timer, uint64_t ticks)

arch_interrupt_global_enable(flags);

return 0;
return ticks;
}

void platform_timer_clear(struct timer *timer)
Expand Down