Repository navigation
timer: fix return values of platform_timer_set and arch_timer_set - #1918
Merged
Merged
Conversation
tlauda
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 10, 2019 12:31
jajanusz
approved these changes
Oct 10, 2019
paulstelian97
approved these changes
Oct 10, 2019
dbaluta
reviewed
Oct 10, 2019
Collaborator
There was a problem hiding this comment.
Change looks good to me. If you have nothing against I would suggest adding the Fixes tag.
Fixes tag is described here:
It should be something like this:
Fixes: xxxxxxx ("commit subject of the fixed commit")
xxxx - should be around 12 digits of the fixed commit hash.
Contributor
Author
There was a problem hiding this comment.
@dbaluta Done. Could you verify whether I've done it correctly?
Collaborator
There was a problem hiding this comment.
@tlauda Looks good, GH links to the commit itself. Not sure if 12 digits are actually needed on this repo (they may be needed on the Linux one) but I digress.
Fixes return value of platform_timer_set and arch_timer_set functions. Change was introduced for cAVS platforms, which accidentally broke these functions for other platforms. The intention of this functions is to return value of set ticks, so the timer scheduler can check for delays. Fixes: 75188e2 ("timer: rework timer_set() so it verifies requested ticks") Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/byt-timer-set-fix
branch
from
October 10, 2019 13:11
5700454 to
938652a
Compare
dbaluta
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes return value of platform_timer_set and arch_timer_set functions.
Change was introduced for cAVS platforms, which accidentally broke
these functions for other platforms. The intention of this functions
is to return value of set ticks, so the timer scheduler can check
for delays.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com