Skip to content

ipc: fix dst size of read in mailbox_validate() - #1327

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
tlauda:topic/mailbox-validate-fix
Apr 26, 2019
Merged

lgirdwood merged 1 commit into
thesofproject:masterfrom
tlauda:topic/mailbox-validate-fix

Conversation

@tlauda

@tlauda tlauda commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

Fixes destination size of mailbox_hostbox_read() call
in mailbox_validate(). We're starting from some non-zero
offset, so the size is smaller than SOF_IPC_MSG_MAX_SIZE.

Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com

Fixes destination size of mailbox_hostbox_read() call
in mailbox_validate(). We're starting from some non-zero
offset, so the size is smaller than SOF_IPC_MSG_MAX_SIZE.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
@keqiaozhang

keqiaozhang commented Apr 26, 2019 •

Copy link
Copy Markdown
Collaborator

#1263 cannot be reproduced on GLK after applying PR #1326 and PR #1327. I got 10K iterations pass. But need to apply PR#849 and PR#850 in kernel side.

Test recipe:
kernel: sof-dev + PR#849 and PR#850
sof: master +PR #1326 and PR #1327.

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@lgirdwood

Copy link
Copy Markdown
Member

@zrombel this should be P1 for CI.

@lgirdwood lgirdwood added the P1 Blocker bugs or important features label Apr 26, 2019
@zrombel

zrombel commented Apr 26, 2019

Copy link
Copy Markdown

CI Pass. Ready for merging.

@lgirdwood
lgirdwood merged commit aa9066c into thesofproject:master Apr 26, 2019
@tlauda
tlauda deleted the topic/mailbox-validate-fix branch November 22, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants