Skip to content

mailbox: fix dst size of mailbox write functions - #1326

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
tlauda:topic/mailbox-fix-dst-size
Apr 26, 2019
Merged

mailbox: fix dst size of mailbox write functions#1326
lgirdwood merged 1 commit into
thesofproject:masterfrom
tlauda:topic/mailbox-fix-dst-size

Conversation

@tlauda

@tlauda tlauda commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

Fixes destination size used by mailbox write functions.
Subtraction of the base address shouldn't be part
of this size calculation.

Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com

@tlauda
mailbox: fix dst size of mailbox write functions
cbdd0e7 
Fixes destination size used by mailbox write functions.
Subtraction of the base address shouldn't be part
of this size calculation.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
@ranj063

ranj063 commented Apr 26, 2019

Copy link
Copy Markdown
Collaborator

@tlauda i have a feeling this might be the fix for #1263. Im testing it now

@keyonjie

keyonjie commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

@tlauda good catch, how could this work?!

@ranj063

ranj063 commented Apr 26, 2019

Copy link
Copy Markdown
Collaborator

@tlauda good catch, how could this work?!

Do you mean how did this work before?

@keyonjie

keyonjie commented Apr 26, 2019

Copy link
Copy Markdown
Contributor

@tlauda good catch, how could this work?!

Do you mean how did this work before?

exactly, :)

@ClarexZhou ClarexZhou mentioned this pull request Apr 26, 2019
Closed
@keqiaozhang keqiaozhang mentioned this pull request Apr 26, 2019
Merged
@keqiaozhang

keqiaozhang commented Apr 26, 2019

Copy link
Copy Markdown
Collaborator

#1263 cannot be reproduced on GLK after applying PR #1326 and PR #1327. I got 10K iterations pass. But need to apply PR#849 and PR#850 in kernel side.

Test recipe:
kernel: sof-dev + PR#849 and PR#850
sof: master +PR #1326 and PR #1327.

@lgirdwood lgirdwood added the P1 Blocker bugs or important features label Apr 26, 2019
@lgirdwood

lgirdwood commented Apr 26, 2019

Copy link
Copy Markdown
Member

@zrombel another CI P1
@jajanusz can you review so we can merge as soon as CI passes.

@zrombel

zrombel commented Apr 26, 2019

Copy link
Copy Markdown

CI PASS. PR can be merged.

@lgirdwood

lgirdwood commented Apr 26, 2019

Copy link
Copy Markdown
Member

@zrombel thanks. We need one more reviewer before we can merge. @lbetlej @mmaka1 ping

ranj063
ranj063 approved these changes Apr 26, 2019
View reviewed changes

@ranj063 ranj063 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my test on GLK passed 10K iterations as well. Thanks @tlauda

@lgirdwood
lgirdwood merged commit f846f7e into thesofproject:master Apr 26, 2019
@tlauda
tlauda deleted the topic/mailbox-fix-dst-size branch November 22, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranj063 ranj063 ranj063 approved these changes
@lgirdwood lgirdwood lgirdwood approved these changes
@lbetlej lbetlej Awaiting requested review from lbetlej
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@plbossart plbossart Awaiting requested review from plbossart

Assignees

No one assigned

Labels

P1 Blocker bugs or important features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tlauda @ranj063 @keyonjie @keqiaozhang @lgirdwood @zrombel