Repository navigation
[RFC] topology: add mux topology for apl and cml - #1316
Conversation
|
this is to be used with @akloniex fw branch: you also need: with these you can load the mux example topology in up2. Topology is pretty similar to sof-apl-pcm512x except for mux record branch. |
|
@akloniex there's now mux topology for cml also if you guys want to give it a try... |
7a89b9f to
56fb99e
Compare
|
@akloniex updated for demux/mux in cml-004-drop-stable branch |
|
@akloniex @tlauda @lgirdwood can you take a look at: |
|
@ranj063 updated with single muxdemux component. Also scheduler comp definition for pipeline now updated. Still missing comments cleaning from new files... can you check also the discussion above. |
|
with this update I can playback and record to and from demux pipeline. As there is no volume components you have to use S32 or S24 format. See the discussion for detailed explanation... |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
This is the second time I've reviewed this PR and made the same comments, none of which were addressed first time around.
|
@juimonen instead of duplicating all the pipelines in sof-apl-pcm512x and sof-cml-rt5682 to add the echo ref pipeline, can we just include sof-pcm-512x.m4/sof-cmlrt5682 and only add the echoref pipeline? Have a look at sof-cml-rt5682-max*.m4 for reference. It does something similar to add just the speaker playback pipeline. |
|
@ranjani I have separate patches for pipeline and topology. I see both you and @lgirdwood are commenting on @akloniex patch so I'll forward the changes to him... @akloniex patch was here just for ease the testing for others, but obviously it was a mistake |
|
@ranjani, yes definitely can look into including the original pipelines. I was just trying to make this very clear and easy for myself, as I was fighting for one day with m4 after forgetting a include file :) |
juimonen
changed the title
|
@ranj063 now looking at the "include" -way, I'm replacing the main playback pipeline in CML and ALP with demux and connecting reference recording pipe to it. So it doesn't work very nicely with includes. So it is not just additional pipe/dai, but replacing/modifying the existing ones. |
This topology will add a capture branch back from playback pipeline's mux component. It can be used for example as a echo cancellation reference signal. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
juimonen
changed the title
|
@ranj063 @lgirdwood updated topology with virtual widget connection to recording dai. This topology was working in APL (apl-demux) and WHL (cml-demux). |
|
@akloniex is there anything pending on your side for demux that would break this ? Have you also tested this topology ? |
|
@juimonen this graph looks complex from the text, can you paste the graph in image format here too. |
|
@lgirdwood |
|
@plbossart is this graph aligned with your approval ? |
|
We will live with this in short term and redo the architecture in SOF 1.4 |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Approved, but we can rework in v1.4
This topology will add a capture branch back
from playback pipeline's mux component. It can
be used for example as echo cancellation reference
signal.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com