Skip to content

ASoC: SOF: topology: add support for mux processing component - #870

Merged
plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
juimonen:mux_topology
May 21, 2019
Merged

plbossart merged 1 commit into
thesofproject:topic/sof-devfrom
juimonen:mux_topology

Conversation

@juimonen

Copy link
Copy Markdown

Add enumerations to support mux processing component.

Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen I am confused by the addition of MUX but not DEMUX, not sure if this is intentional or a mistake.
Either way this looks like an ABI change, no?

Comment thread sound/soc/sof/topology.c Resolved
@wenqingfu wenqingfu added the ABI involves ABI changes, need extra attention label May 1, 2019
@juimonen

juimonen commented May 3, 2019

Copy link
Copy Markdown
Author

with this update I can playback and record to and from demux pipeline. As there is no volume components you have to use S32 or S24 format. See the discussion for detailed explanation...

@juimonen

juimonen commented May 3, 2019

Copy link
Copy Markdown
Author

@plbossart @lgirdwood check the commit about fe/be connection, I know it is quite a hack, but I'm not sure if the check is needed normally? I'm open to suggestions how to do this properly...

Comment thread sound/soc/soc-pcm.c Resolved
@juimonen juimonen changed the title [RFC][Do not merge] ASoC: SOF: topology: add support for mux processing component [RFC] ASoC: SOF: topology: add support for mux processing component May 6, 2019

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @juimonen the patch 'ASoC: pcm: support FEs without BEs' is just too invasive and will impact other drivers.

Comment thread sound/soc/soc-pcm.c Resolved
Add enumerations to support mux/demux processing component.

Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
@juimonen

juimonen commented May 8, 2019

Copy link
Copy Markdown
Author

@plbossart @lgirdwood updated, controversial fe/be patch removed as I got it working with other topology, see related fw PR1316.

@singalsu singalsu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple and good to me.

Comment thread include/sound/sof/topology.h Resolved
@wenqingfu
wenqingfu requested a review from keyonjie May 8, 2019 22:46
@juimonen juimonen changed the title [RFC] ASoC: SOF: topology: add support for mux processing component ASoC: SOF: topology: add support for mux processing component May 9, 2019
@juimonen

juimonen commented May 9, 2019

Copy link
Copy Markdown
Author

corresponding ABI abi change in FW:
thesofproject/sof#1275

@plbossart

Copy link
Copy Markdown
Member

corresponding ABI abi change in FW:
thesofproject/sof#1275

no MINOR update?

@wenqingfu

Copy link
Copy Markdown

SOFCI TEST

@plbossart

Copy link
Copy Markdown
Member

@lgirdwood Tired of waiting for firmware folks, will merge now to unlock tests for the upcoming release. I'll add the MINOR version in the upstream code when there is a decision on MINOR 7 or MINOR8.

@plbossart
plbossart merged commit cd01004 into thesofproject:topic/sof-dev May 21, 2019
@wenqingfu

Copy link
Copy Markdown

Since the leading vehicle of MINOR 7 (PR 756) has been merged, there is probably no need for a version update, as long as the corresponding firmware patch be integrated before the next leading vehicle of MINOR 8 (PR 895).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI involves ABI changes, need extra attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants