Skip to content

pipeline: trigger pipelines with the same sched comp #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Apr 15, 2019
Merged

pipeline: trigger pipelines with the same sched comp #1228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/audio/pipeline.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,12 +462,19 @@ static void pipeline_comp_trigger_sched_comp(struct pipeline *p,
static int pipeline_comp_trigger(struct comp_dev *current, void *data, int dir)
{
struct pipeline_data *ppl_data = data;
int is_single_ppl = comp_is_single_pipeline(current, ppl_data->start);
int is_same_sched =
pipeline_is_same_sched_comp(current->pipeline,
ppl_data->start->pipeline);

@dbaluta dbaluta Apr 5, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you put pipeline_is_same_sched_comp on the same line with int is_same_sched? It does fit inside 80 char limit.

@tlauda tlauda Apr 8, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbaluta But then ppl_data->start->pipeline can't be aligned with opening bracket, because it will exceed 80 chars.

@dbaluta dbaluta Apr 11, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ok. I see your point.

int err = 0;

tracev_pipe("pipeline_comp_trigger(), current->comp.id = %u, dir = %u",
current->comp.id, dir);

if (!comp_is_single_pipeline(current, ppl_data->start)) {
/* trigger should propagate to the connected pipelines,
* which need to be scheduled together
*/
if (!is_single_ppl && !is_same_sched) {
Comment thread
tlauda marked this conversation as resolved.
Resolved
tracev_pipe_with_ids(current->pipeline, "pipeline_comp_trigger"
"(), current is from another pipeline");
return 0;
Expand Down