Repository navigation
pipeline: trigger pipelines with the same sched comp - #1228
Conversation
lgirdwood
left a comment
There was a problem hiding this comment.
Not sure we want to change M4 scheduling config as the media PCM is intended to show mixing of two pipelines with different scheduling configuration e.g. low latency and media decode. We may have to make the media PCM mixer source buffer larger if mixer is starving though....
Changes pipeline behavior to trigger pipelines with the same scheduling component. This change allows for properly triggering topologies with mixer. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
31b9879 to
00368e2
Compare
|
@lgirdwood PCM media pipeline is connected to the low latency pipeline with mixer, but it doesn't have any scheduling component. It should have the same as ll pipeline, so the FW would know it should copy its source. It's the mixer copy thing we have discussed some time ago. It has nothing to do with the buffer size. Both pipelines will still work on the same DMA interrupt. |
|
@tlauda I have some generic questions about pipelines and scheduling components. Feel free
|
| int is_single_ppl = comp_is_single_pipeline(current, ppl_data->start); | ||
| int is_same_sched = | ||
| pipeline_is_same_sched_comp(current->pipeline, | ||
| ppl_data->start->pipeline); |
There was a problem hiding this comment.
Why don't you put pipeline_is_same_sched_comp on the same line with int is_same_sched? It does fit inside 80 char limit.
There was a problem hiding this comment.
@dbaluta But then ppl_data->start->pipeline can't be aligned with opening bracket, because it will exceed 80 chars.
There was a problem hiding this comment.
oh, ok. I see your point.
My question was more about two pipelines that were scheduled differently (whether using different periods or clock domains or both) and joined via the mixer, this is something we should support. |
Yes, definitely, but it's a bigger feature than this simple fix. This patch simply fixes the currently used pipeline topologies with mixer. |
|
@lgirdwood Any thoughts? If you agree with this approach, we could proceed with the topology changes. Of course this is not the final resolution and scheduling of connected pipelines needs to be revisited. |
Changes pipeline behavior to trigger pipelines with
the same scheduling component. This change allows
for properly triggering topologies with mixer.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com