Repository navigation
edf: using specific schedule_edf() instead of schedule() - #1164
Merged
mmaka1 merged 1 commit intoMar 25, 2019
Merged
Conversation
bkokoszx
force-pushed
the
edf-scheduler-function-rename
branch
from
March 21, 2019 13:26
8cb757c to
68dfa92
Compare
tlauda
approved these changes
Mar 21, 2019
lgirdwood
requested changes
Mar 21, 2019
lgirdwood
requested changes
Mar 21, 2019
Member
There was a problem hiding this comment.
Can you state why in commit message, looks like an optimization or bug fix ?
Collaborator
Author
There was a problem hiding this comment.
I've add information that is for optimization. In fact, it was my inattention during #1089 PR. We should not use generic functions in specific scheduler implementation.
Effect is the same, because schedule() will also invoke schedule_edf() function.
bkokoszx
force-pushed
the
edf-scheduler-function-rename
branch
from
March 22, 2019 10:44
68dfa92 to
8f668ba
Compare
I've changed scheduler invocation in schedule_edf_task_normal() from generic schedule() to specific schedule_edf() for optimization (there is no need to use generic functions in specific scheduler implementation). Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
edf-scheduler-function-rename
branch
from
March 22, 2019 10:46
8f668ba to
d910c51
Compare
bkokoszx
changed the title
lgirdwood
approved these changes
Mar 22, 2019
mmaka1
approved these changes
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed scheduler invocation in
schedule_edf_task_normal()from generic
schedule()tospecific schedule_edf()for optimization(there is no need to use generic functions in specific scheduler
implementation).