Repository navigation
scheduler: generic scheduler and work api - #1089
Merged
lgirdwood merged 1 commit intoMar 19, 2019
Merged
Conversation
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
2 times, most recently
from
March 6, 2019 15:19
d4ef1ca to
2d0eafe
Compare
tlauda
suggested changes
Mar 6, 2019
tlauda
left a comment
tlauda
left a comment
Contributor
There was a problem hiding this comment.
In general it's OK.
Just few more unifications needed.
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
3 times, most recently
from
March 6, 2019 16:34
828393b to
5a19c5a
Compare
lgirdwood
requested changes
Mar 6, 2019
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
In general we need to align and unify all our client facing scheduler APIs and structures. We also need to support more priority levels and support different schedulers types (using a structure of function pointers to abstract each scheduler to the core logic).
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
10 times, most recently
from
March 7, 2019 15:47
82f70e3 to
905a2bd
Compare
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
5 times, most recently
from
March 12, 2019 15:46
cc7305d to
885c966
Compare
Collaborator
Author
|
@lgirdwood |
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
from
March 12, 2019 15:55
885c966 to
bcd3189
Compare
tlauda
suggested changes
Mar 13, 2019
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
4 times, most recently
from
March 13, 2019 10:43
68eec0f to
76b841c
Compare
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
from
March 13, 2019 11:14
76b841c to
6f1314f
Compare
tlauda
approved these changes
Mar 13, 2019
Contributor
|
@lgirdwood Now everything looks OK for me. Could you take a look, so we could proceed with further PRs? |
lgirdwood
requested changes
Mar 13, 2019
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Looking in the right direction now. Mostly minor changes needed.
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
2 times, most recently
from
March 15, 2019 16:18
0432bb3 to
8cd1bd6
Compare
jajanusz
approved these changes
Mar 19, 2019
|
HI @lgirdwood, are you ok with this patch? Can we merge it or some additional work is needed? |
This commit: 1. Renames specific schedulers: - schedule (.c/.h) -> edf_schedule (.c/.h) - work (.c/.h) -> ll_schedule (.c/.h) 2. Implements new generic scheduler api based on generic struct with scheduler ops. Every specific scheduler exports struct with pointers to its specific functions. 3. Makes edf and ll using generic api (exports structure with pointers to its own specific functions) 4. Updates host and pipeline tests due to scheduler changes. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
scheduler-generic-api-rebase
branch
from
March 19, 2019 07:53
8cd1bd6 to
748a6a7
Compare
lgirdwood
approved these changes
Mar 19, 2019
This was referenced Mar 22, 2019
This was referenced Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides generic scheduler API. Source API code is placed in schedule (.c/.h) sources.
Specific existing schedulers were renamed:
Each scheduler export structure with pointers to its own, specific functions. API using task type, selects proper scheduler specific function and calls it.