Repository navigation
multiple-pipeline: skip Echo Reference pipeline when getting count - #875
Merged
Merged
Conversation
keqiaozhang
previously approved these changes
Mar 9, 2022
keqiaozhang
left a comment
keqiaozhang
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
@miRoox ,thanks for the fix, I missed this case.
Contributor
Author
|
Tested on ADLP_BRYA_SDW and TGLU_VOLT_SDW, the inner test report 10814 is all green. |
marc-hb
reviewed
Mar 9, 2022
Previously, the Echo Reference pipeline has been skipped when running the parallel pipeline test, but it wasn't skipped when calculating PIPELINE_COUNT. Therefore, on all pipelines mode, the expected process count is inconsistent with the actual running process. To solve this issue, skip the same pipeline when acquiring the pipeline count for consistency. Signed-off-by: Yongan Lu <yongan.lu@intel.com>
miRoox
force-pushed
the
fix-multiple-pipeline-all
branch
from
March 9, 2022 05:46
1e71508 to
3097725
Compare
marc-hb
approved these changes
Mar 9, 2022
keqiaozhang
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Echo Reference pipeline has been skipped when running
the parallel pipeline test, but it wasn't skipped when calculating
PIPELINE_COUNT. Therefore, on all pipelines mode, the expected process
count is inconsistent with the actual running process. To solve this
issue, skip the same pipeline when acquiring the pipeline count for
consistency.
Signed-off-by: Yongan Lu yongan.lu@intel.com