Skip to content

sof-kernel-log-check: ignore ACPI _ADR workaround #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
plbossart wants to merge 1 commit into from
Closed

sof-kernel-log-check: ignore ACPI _ADR workaround #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/sof-kernel-log-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,11 @@ ignore_str="$ignore_str"'|proc_thermal 0000:00:..\..: No auxiliary DTSs enabled'
# elan_i2c i2c-ELAN0000:00: invalid report id data (ff)
ignore_str="$ignore_str"'|elan_i2c i2c-ELAN0000:.*: invalid report id data'

# SoundWire workaround using RT701
# https://github.com/thesofproject/linux/pull/2701
ignore_str="$ignore_str"'|rt711 sdw:[0-3]:25d:701:0: Probe of rt711 failed: -19'
ignore_str="$ignore_str"'|rt1308 sdw:[0-3]:25d:701:0: Probe of rt1308 failed: -19'

@marc-hb marc-hb Jan 24, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you guard this with:

if [ "$platform" = xxx ] ; then
  ignore_str="$ignore_str"'|rt711 ...'
  ignore_str="$ignore_str"'|rt1308 ...'
fi

The PR URL is super useful but... very long! Can you also add just a couple words like:

# some BIOSes are  buggy so we need to probe like mad.

This helps a lot with future maintenance of this file.

#
# SDW related logs
#
Expand Down