Repository navigation
Conversation
PR thesofproject/linux#2701 introduces a workaround which leads to errors being thrown when the DSDT contains a device with the 0x701 part_id. Ignore the error since it's a normal error flow. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Member
Author
|
@marc-hb GitActions issue here unrelated to this PR? |
marc-hb
requested changes
Jan 24, 2021
| # https://github.com/thesofproject/linux/pull/2701 | ||
| ignore_str="$ignore_str"'|rt711 sdw:[0-3]:25d:701:0: Probe of rt711 failed: -19' | ||
| ignore_str="$ignore_str"'|rt1308 sdw:[0-3]:25d:701:0: Probe of rt1308 failed: -19' | ||
|
|
Collaborator
There was a problem hiding this comment.
Can you guard this with:
if [ "$platform" = xxx ] ; then
ignore_str="$ignore_str"'|rt711 ...'
ignore_str="$ignore_str"'|rt1308 ...'
fi The PR URL is super useful but... very long! Can you also add just a couple words like:
# some BIOSes are buggy so we need to probe like mad.This helps a lot with future maintenance of this file.
Member
Author
|
no longer needed, we chose a different implementation in the Linux kernel. |
marc-hb
added
area:non-audio Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR thesofproject/linux#2701 introduces a
workaround which leads to errors being thrown when the DSDT contains a
device with the 0x701 part_id.
Ignore the error since it's a normal error flow.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com