Repository navigation
sof-kernel-log-check: ignore USB hub issues - #432
Conversation
|
Considering this seems like a generic USB error it would probably be better to guard this with |
Why? there's nothing platform specific here? It's probably just the hub I used that's not handled. |
|
I thought that hub was embedded in the system, was it external? The description says "needed for on CHT devices". If it was external can't you use another hub or ignore this error just locally? A bit concerned this file could grow into a database of defective peripherals... Also not a fan of ignoring errors with random external hubs and hiding at the same time any errors with embedded, possibly Intel hubs. |
|
@marc-hb I don't get why you are making things more complicated than they need to be. There's an issue on a device I use, the hub is actually in my keyboard, I don't have spare hubs and it is what is is. That device alone flagged major issues with sof-test, between a broken ACPI handling and broken card name parsing so you should thank me for going beyond the reasonable in hardening tests. End of discussion, nothing to see here. |
|
There's really nothing complicated in being concerned that this file becomes a dump of everyone's broken devices and trying to mitigate that a bit. The quality level I'm trying to raise sof-test to is not 1/10th of the nitpicking found in a typical kernel code review. Of course that's because few people care about sof-test but that's a not a very good reason IMHO because role-modelling etc. I'm "thanking you" by reviewing (and immediately approving!!) this PR and reviewing the majority of PRs in sof-test which is rare enough. I really appreciate that your involvement with sof-test is 10 times the SOF developer average's but first I think mine is still higher than yours and second the important topic here is not our respective levels of involvement in sof-test but the very low average level and how developers test their code. Anyway no one should be thanking anyone else for contributing to sof-test specifically because sof-test is not anyone's project, it's just one part of the larger SOF project which is much more your project than mine. So don't forget to thank me :-) |
|
The code change is good, but may add a backslash |
no, this is a regexp, there's no actual point |
USB2 issues are not really relevant, and may occur with various peripherals. Add them to the filter list with wildcards. BugLink: thesofproject#431 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
rebased and added a wildcard to discard all usb2/hub2 issues. |
marc-hb
added
the
area:non-audio Failure
This is needed on CHT devices
BugLink: #431
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com