Repository navigation
test-case: add missing pipeline count acquisition logic - #380
Conversation
Forgot to mention it's intermittently empty on my Up2 board. This fix does not look like a fix for a non-deterministic issue... @aiChaoSONG what's your logger experience when running the multipipeline tests? Before and after this PR? UPDATE after a bit more testing: not intermittently empty: empty the second time I run |
8d877a9 to
3605f6a
Compare
|
@marc-hb Before this PR, the test case always PASS, even the topology not loaded(should fail), and the terminal message like this: After this PR, if topology loaded, terminal message looks like this: In fact, before this PR, no pipeline is checked, that's why it always pass. |
3605f6a to
b711898
Compare
The commit 84f5895 wrongly remove the code logic to acquire pipeline count from multi-pipeline-playback/ capture test cases. This leads to the 'max_count' used in these scripts being empty, as no pipeline is actually tested, the test cases will always pass. This patch adds the pipeline count acquisition logic back. Signed-off-by: Amery Song <chao.song@intel.com>
|
merge for tgl release |
fredoh9
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
The commit 84f5895 wrongly remove the code logic to
acquire pipeline count from multi-pipeline-playback/
capture test cases. This leads to the 'max_count' used
in these scripts being empty, as no pipeline is actually
tested, the test cases will always pass.
This patch adds the pipeline count acquisition logic back.