Skip to content

multiple-pipeline-{capture,playback}.sh are broken #324

Closed

Description

@lyakh

The multiple-pipeline-playback.sh and multiple-pipeline-capture.sh scripts are broken, they do nothing. They check $PIPELINE_COUNT before parsing topology by calling func_pipeline_export

Activity

  1. added
    type:bugSomething doesn't work as expected
    on Aug 7, 2020
  2. changed the title [-]multiple-pipeline-playback.sh is broken[/-] [+]multiple-pipeline-{capture,playback}.sh are broken[/+] on Aug 7, 2020
  3. plbossart commented on Aug 12, 2020

    @plbossart
    Member

    @lyakh do you mean to say that this line is wrong?

    [[ $PIPELINE_COUNT -gt ${OPT_VALUE_lst['c']} ]] && max_count=${OPT_VALUE_lst['c']} || max_count=$PIPELINE_COUNT
    f
    

    I must say I have zero understanding of these scripts.

  4. lyakh commented on Sep 1, 2020

    @lyakh
    ContributorAuthor

    @lyakh do you mean to say that this line is wrong?

    [[ $PIPELINE_COUNT -gt ${OPT_VALUE_lst['c']} ]] && max_count=${OPT_VALUE_lst['c']} || max_count=$PIPELINE_COUNT
    f
    

    I must say I have zero understanding of these scripts.

    @plbossart it isn't about the contents of that line, it's about when it is executed, respectively when the $PIPELINE_COUNT variable is evaluated. Evaluating it before it is set makes no sense and it is only set in func_pipeline_export()

  5. aiChaoSONG commented on Sep 23, 2020

    @aiChaoSONG

    @lyakh This is fixed by #380, thanks. let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething doesn't work as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions