Skip to content

env-check: add sof-dyndbg.conf file check #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fredoh9 wants to merge 1 commit into from
Closed

env-check: add sof-dyndbg.conf file check #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion env-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/bin/bash

# enable dynamic debug logs for SOF modules
DYNDBG="/etc/modprobe.d/sof-dyndbg.conf"

# check for the system package
out_str=""
func_check_pkg(){
Expand All @@ -24,14 +27,25 @@ func_check_python_pkg(){
fi
}

func_check_file(){
if [ -e "$1" ]; then
return
fi
out_str=$out_str"\nOptional: Enable dynamic debug logs on \e[31m $1 \e[0m file\n\tFor example,\n\toptions snd_sof dyndbg=+p\n\toptions snd_sof_pci dyndbg=+p"
check_res=1
}

check_res=0
echo -ne "Check for the package:\t\t"
func_check_pkg expect
func_check_pkg aplay
func_check_pkg python3
func_check_python_pkg graphviz
func_check_file "$DYNDBG"
[[ $check_res -eq 0 ]] && echo "pass" || \
echo -e "\e[31mWarning\e[0m\nSolution:"$out_str
# We know exactly what $out_str is, it's not some random and unsanitized input
# shellcheck disable=SC2059
printf '\e[31mWarning\e[0m\nSolution:'"$out_str"'\n'

@marc-hb marc-hb Jul 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work, it prints the warning every time because the backslash applies only to the comment line. This totally confuses shellcheck BTW, did you run shellcheck?

false || \
# only the comment is "backslashed"
   printf 'RUNS ANYWAY'

Move # shellcheck disable earlier before the start of the "real line"


# check for the tools folder
old_path=$PWD
Expand Down