Repository navigation
Conversation
975bc36 to
2cf67cc
Compare
|
Debug log verbosity was discussed in thesofproject/linux#2204 as well. Same sof-dyndbg.conf to all test devices are very much required. |
right, but the contents of sof-dyndbg.conf should be discussed. |
2cf67cc to
ac610ea
Compare
ac610ea to
7a318c8
Compare
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
missing quotes. First warning reported by shellcheck.
daa683c to
46f572d
Compare
Check sof-dyndbg.conf available in the system, give optional warning and
print short usage of dyndbg for SOF modules.
ShellCheck error, SC2059 is ignored.
printf '\e[31mWarning\e[0m\nSolution:'"$out_str"'\n'
^-- SC2059: Don't use variables in the printf format string. Use printf "..%s.." "$foo".
Signed-off-by: Fred Oh <fred.oh@linux.intel.com>
| echo -e "\e[31mWarning\e[0m\nSolution:"$out_str | ||
| # We know exactly what $out_str is, it's not some random and unsanitized input | ||
| # shellcheck disable=SC2059 | ||
| printf '\e[31mWarning\e[0m\nSolution:'"$out_str"'\n' |
There was a problem hiding this comment.
This doesn't work, it prints the warning every time because the backslash applies only to the comment line. This totally confuses shellcheck BTW, did you run shellcheck?
false || \
# only the comment is "backslashed"
printf 'RUNS ANYWAY'Move # shellcheck disable earlier before the start of the "real line"
|
re-submitted without the echo/printf change at #309 |
Check sof-dyndbg.conf available in the system, give optional warning and
short usage of dyndbg for SOF modules.
Signed-off-by: Fred Oh fred.oh@linux.intel.com
Output file:
deploy.sh change will be merged soon. This can fix
#173