Repository navigation
Topic/sof dev cleanup1 - #14
Conversation
There was a problem hiding this comment.
checkpatch issues:
WARNING: 'mesage' may be misspelled - perhaps 'message'?
#92: FILE: sound/soc/sof/ipc.c:158:
- /* add mesage to transmit list */
WARNING: 'mesage' may be misspelled - perhaps 'message'?
#113: FILE: sound/soc/sof/ipc.c:182:
- /* send message if HW read and mesage in TX list */
CHECK: Please don't use multiple blank lines
#267: FILE: sound/soc/sof/ipc.c:366:
+
+
WARNING: 'postion' may be misspelled - perhaps 'position'?
#453: FILE: sound/soc/sof/ipc.c:478:
+/* get stream postion IPC - use faster MMIO method if available on platform */
8f60185 to
0dcb3bf
Compare
commented
Jul 3, 2018
|
Checkpatch done, I'll be doing sparse as a separate PR |
There was a problem hiding this comment.
is this going to work for topic/sof-v4.14?
There was a problem hiding this comment.
gah, part of the post 4.18+ component API updates. Will revert for 4.14.
There was a problem hiding this comment.
Done, and also created a debug option submenu where stuff like this can go
Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
…er funcs Add comments describing funcs/code blocks and reorder funcs so features are grouped. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
f34344c to
b66e8ef
Compare
3 participants
Cleanup of code for upstreaming, some function reorg to group functions by feature and commets added to some code blocks.
Separated into multiple patches for easier squashing.