Skip to content

Harden APL/GLK hardware support #87

Closed

Description

@plbossart

The current driver does not implement all the recommended hardware setups

Adding a blanket bug to cover all these improvements. Filed as a bug since the current code is not robust enough.

Activity

  1. added
    enhancementNew feature or request
    and removed
    bugSomething isn't working
    on Sep 18, 2018
  2. mengdonglin commented on Sep 18, 2018

    @mengdonglin

    This is an enhancement, so change label from bug to 'enhancement', still P2 to get attention.

  3. added
    P1Blocker bugs or important features
    and removed
    P2Critical bugs or normal features
    on Jan 1, 2019
  4. ranj063 commented on Jan 1, 2019

    @ranj063
    Collaborator

    The current driver does not implement all the recommended hardware setups

    • 1. firmware download needs to be retried
    • 2. power-gating and clock gating needs to be disabled during firmware download
    • 3. some bits are not reprogrammed on resume
    • 4. watchdog and recovery needed
    • 5. delays after programming registers (and/or loops to check status changes)
    • 6. set I2S as slave before enabling DSP
    • 7. avoid DMA resume capability on capture

    Adding a blanket bug to cover all these improvements. Filed as a bug since the current code is not robust enough.
    @mengdonglin the ones that I checked are already done

  5. plbossart commented on Mar 24, 2019

    @plbossart
    MemberAuthor

    @wenqingfu can we get someone assigned to this? We know our programming sequences don't fully follow recommended guidelines, let's fix those known opens, at least the opens 2, 5, 6 and keep watchdog/recovery and DAM resume capability aside.

  6. plbossart commented on Jun 10, 2019

    @plbossart
    MemberAuthor

    @zhuyingjiang can you clarify what remains to be done for this issue?

  7. zhuyingjiang commented on Jun 11, 2019

    @zhuyingjiang

    @plbossart The remains are:
    4. watchdog and recovery needed
    7. avoid DMA resume capability on capture

    The 5. #777 delays after programming registers (and/or loops to check status changes)
    is almost been done after my PR #1020 #997 is merged.
    Still there may need one more PR for "set DUM bit on device power up"

  8. plbossart commented on Jan 9, 2020

    @plbossart
    MemberAuthor

    we are not going to support DMA resume, so forking the firmware recovery as a separate issue #1675

  9. added a commit that references this issue on May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Blocker bugs or important featuresenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions