setup.py test doesn't pass on clean repo clone #3

Activity

1. graysonarts

   assigned

   shinchris

   on Sep 2, 2016
2. graysonarts

   added this to the 0.1 milestone on Sep 2, 2016
3. graysonarts commented on Sep 2, 2016

   

   graysonarts

   on Sep 2, 2016

   Contributor

   More actions

   @shinchris This is because you are missing __init__.py in the test directory.
4. t8y8 commented on Sep 2, 2016

   

   t8y8

   on Sep 2, 2016

   Last edited by t8y8

   ContributorAuthor

   More actions

   Adding an empty __init__ file gets them to run, I've got 9 failures on python 3

   It's due to relative import problems.

   I fixed one by saying from .exceptions import <blah> but then there's another.

   Example:

   ImportError: Failed to import test module: test_workbook
   Traceback (most recent call last):
     File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/unittest/loader.py", line 153, in loadTestsFromName
       module = __import__(module_name)
     File "/Users/tdoyle/Documents/py/server-api-python/test/test_workbook.py", line 4, in <module>
       import tableauserverapi as TSA
     File "/Users/tdoyle/Documents/py/server-api-python/tableauserverapi/__init__.py", line 2, in <module>
       from .models import ConnectionItem, DatasourceItem,\
     File "/Users/tdoyle/Documents/py/server-api-python/tableauserverapi/models/__init__.py", line 2, in <module>
       from .datasource_item import DatasourceItem
     File "/Users/tdoyle/Documents/py/server-api-python/tableauserverapi/models/datasource_item.py", line 3, in <module>
       from tag_item import TagItem
   ImportError: No module named 'tag_item'
   
5. graysonarts commented on Sep 2, 2016

   

   graysonarts

   on Sep 2, 2016

   Contributor

   More actions

   Definitely need to get these fixed before we can release 0.1
6. t8y8 commented on Sep 2, 2016

   

   t8y8

   on Sep 2, 2016

   Last edited by t8y8

   ContributorAuthor

   More actions

   I'm trying to run through them all now, I can attach a unified diff as a starting point

   Edit: Tests now run without import errors, still failures. Taking a look

   👍React with 👍1Reacted by Grayson
7. t8y8 commented on Sep 2, 2016

   

   t8y8

   on Sep 2, 2016

   Last edited by t8y8

   ContributorAuthor

   More actions

   Coolio.

   Attached is a diff that will fix the import errors.
   fixed_imports.txt

   And an output from the failures. Looks like a lot of typeerrors with str:
   failures.txt

   Example:

   ======================================================================
   ERROR: test_get (test.test_group.GroupTests)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/Users/tdoyle/Documents/py/server-api-python/test/test_group.py", line 27, in test_get
       m.get(self.baseurl, text=response_xml)
     File "/Users/tdoyle/Documents/py/envs/tableau/lib/python3.5/site-packages/requests_mock/mocker.py", line 102, in get
       return self.request(GET, *args, **kwargs)
     File "/Users/tdoyle/Documents/py/envs/tableau/lib/python3.5/site-packages/requests_mock/mocker.py", line 99, in request
       return self.register_uri(*args, **kwargs)
     File "/Users/tdoyle/Documents/py/envs/tableau/lib/python3.5/site-packages/requests_mock/adapter.py", line 304, in register_uri
       responses = [response._MatcherResponse(**k) for k in response_list]
     File "/Users/tdoyle/Documents/py/envs/tableau/lib/python3.5/site-packages/requests_mock/adapter.py", line 304, in <listcomp>
       responses = [response._MatcherResponse(**k) for k in response_list]
     File "/Users/tdoyle/Documents/py/envs/tableau/lib/python3.5/site-packages/requests_mock/response.py", line 200, in __init__
       raise TypeError('Text should be a callback or string data')
   TypeError: Text should be a callback or string data
   

   EDIT:

   It's because we read the xml in as binary mode, in python3 that's not a valid string type.

      def test_update_tags(self):
           with open(ADD_TAGS_XML, 'rb') as file:
               add_tags_xml = file.read()
           with open(UPDATE_XML, 'rb') as file:
               update_xml = file.read()
           with requests_mock.mock() as m:
               m.put(self.baseurl + '/1f951daf-4061-451a-9df1-69a8062664f2/tags', text=add_tags_xml)
   

   Could become:

      def test_update_tags(self):
           with open(ADD_TAGS_XML, 'r') as file:
               add_tags_xml = file.read()
           with open(UPDATE_XML, 'r') as file:
               update_xml = file.read()
           with requests_mock.mock() as m:
               m.put(self.baseurl + '/1f951daf-4061-451a-9df1-69a8062664f2/tags', text=add_tags_xml)
   

   Or, more correctly:

      def test_update_tags(self):
           with open(ADD_TAGS_XML, 'rb') as file:
               add_tags_xml = file.read().decode('utf-8)
           with open(UPDATE_XML, 'rb') as file:
               update_xml = file.read().decode('utf-8)
           with requests_mock.mock() as m:
               m.put(self.baseurl + '/1f951daf-4061-451a-9df1-69a8062664f2/tags', text=add_tags_xml)
   
8. shinchris

   added a commit that references this issue on Sep 8, 2016

   #3 addressing test failures (#15)

   ...

   9fcf7e6
9. shinchris

   closed this as completedon Sep 8, 2016