Skip to content

#3 addressing test failures - #15

Merged
shinchris merged 4 commits into
developmentfrom
bugfix-3-tests
Sep 8, 2016
Merged

#3 addressing test failures#15
shinchris merged 4 commits into
developmentfrom
bugfix-3-tests

Conversation

@shinchris

@shinchris shinchris commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

No description provided.

t8y8
t8y8 reviewed Sep 7, 2016
View reviewed changes
Comment thread tableauserverapi/models/datasource_item.py Outdated

@t8y8 t8y8 Sep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor: type is a keyword/builtin function as well

@t8y8

t8y8 commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

🚀

Two small comments

@shinchris
shinchris force-pushed the bugfix-3-tests branch 2 times, most recently from 88e6c7a to 4b7062b Compare September 7, 2016 21:13
t8y8
t8y8 reviewed Sep 7, 2016
View reviewed changes
Comment thread test/test_user.py Outdated

@t8y8 t8y8 Sep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just set()

@graysonarts

graysonarts commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

🚀

@t8y8

t8y8 commented Sep 7, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

view_item.py causes a test failure on py3, it needs the '.'

import xml.etree.ElementTree as ET
from exceptions import UnpopulatedPropertyError
from .. import NAMESPACE

But fixing that gets all 91 tests passing on Py2 and py3!!!

@shinchris
shinchris merged commit 9fcf7e6 into development Sep 8, 2016
@shinchris
shinchris deleted the bugfix-3-tests branch September 8, 2016 16:34
@shinchris
shinchris restored the bugfix-3-tests branch September 8, 2016 18:08
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
Russell Hay
Merge pull request tableau#15 from t8y8/xml-root-tag-fix
ef2eaa4 
Fix for issue tableau#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shinchris @t8y8 @graysonarts