Skip to content

Add modelsToIgnore option - #235

Closed
aquid wants to merge 1 commit into
strongloop:masterfrom
aquid:master
Closed

aquid wants to merge 1 commit into
strongloop:masterfrom
aquid:master

Conversation

@aquid

@aquid aquid commented Aug 21, 2016 •

Copy link
Copy Markdown
Contributor
  • Added a new parameter named as modelsToIgnore which stores a list of models that are to be prevented from being published in loopback angular SDK
  • Added tests for testing modelToIgnore feature

This PR is an update for #224
cc @bajtos @pulkitsinghal

… of models that are to be prevented from being generated and made available through angular

- Added tests for testing modelToIgnore
@slnode

slnode commented Aug 21, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

slnode commented Aug 21, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@aquid

aquid commented Aug 21, 2016

Copy link
Copy Markdown
Contributor Author

@bajtos Had some rebase issues with the previous PR #224 , so I have updated the commits with new changes and merged it into single commit.

@aquid aquid mentioned this pull request Aug 21, 2016
@bajtos

bajtos commented Aug 24, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos

bajtos commented Aug 24, 2016

Copy link
Copy Markdown
Member

The Commit Linter failure means your commit message does not follow the 50/27 rule, please fix.

@bajtos bajtos self-assigned this Aug 24, 2016
@bajtos

bajtos commented Aug 24, 2016

Copy link
Copy Markdown
Member

@aquid other than my comment above, the patch is good to be landed.

@bajtos

bajtos commented Aug 24, 2016

Copy link
Copy Markdown
Member

I made the changes myself and landed the patch.

Thank you @aquid for your contribution!

@aquid

aquid commented Aug 24, 2016

Copy link
Copy Markdown
Contributor Author

@bajtos Thanks for your help. It was great learning from this PR and your suggestions helped a lot.

Can you help me with the version number where this change will reflect.

@bajtos

bajtos commented Aug 24, 2016

Copy link
Copy Markdown
Member

Released loopback-sdk-angular@1.10.0, enjoy :)

aquid added a commit to aquid/grunt-loopback-sdk-angular that referenced this pull request Aug 29, 2016
Since the PR was approved, strongloop/loopback-sdk-angular#235, so updating the version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants