Skip to content

Add modelsToIgnore option - #224

Closed
aquid wants to merge 0 commit into
strongloop:masterfrom
aquid:master
Closed

aquid wants to merge 0 commit into
strongloop:masterfrom
aquid:master

Conversation

@aquid

@aquid aquid commented Jun 15, 2016 •

Copy link
Copy Markdown
Contributor

… contains a list of models that are to be prevented from being published in loopback angular SDK.

cc @bajtos

@slnode

slnode commented Jun 15, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@bajtos

bajtos commented Jun 20, 2016

Copy link
Copy Markdown
Member

@aquid thank you for the contribution. Could you please sign our Contributor License Agreement here? I cannot land the pull request without that.

Also please

@bajtos

bajtos commented Jun 20, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

Comment thread lib/services.js Outdated
options = {
ngModuleName: arguments[1],
apiUrl: arguments[2],
modelsToIgnore: arguments[3] ? arguments[3] : []

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is for the legacy API that should not be extended by new features. Please remove this line.

@bajtos

bajtos commented Jun 20, 2016

Copy link
Copy Markdown
Member

@aquid also please add a unit-test to verify your new feature and prevent regressions in the future. You can inspire by the tests added by 61b3641.

@bajtos bajtos self-assigned this Jun 20, 2016
@bajtos bajtos added the feature label Jun 20, 2016
@pulkitsinghal

Copy link
Copy Markdown

@bajtos - please review this #226 before Aquid gets going otherwise he'll also be fixing stuff and not making checkins that are purely related to his theme

@aquid

aquid commented Jun 27, 2016

Copy link
Copy Markdown
Contributor Author

Made the changes to remove console.error to console.warn and added unit test for testing the feature.
dec5b34

cc @bajtos @superkhau @pulkitsinghal

@pulkitsinghal

pulkitsinghal commented Jul 22, 2016 •

Copy link
Copy Markdown

Hey @bajtos, can you once again ask the system to:

@slnode ok to test

@slnode

slnode commented Jul 22, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

Comment thread test.e2e/spec/services.spec.js Outdated
});
});

describe('$resource not generated for ignonred models', function() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: ignonred, should be ignored.

@bajtos

bajtos commented Jul 27, 2016

Copy link
Copy Markdown
Member

Left two comments. @aquid After you address them, could you please rebase your patch on top of the latest master and squash all commits into a single one, with a descriptive commit message following 50/27 rule.

@bajtos

bajtos commented Jul 27, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos bajtos changed the title Added modelToIgnore option which… Add modelsToIgnore option Jul 27, 2016
@aquid aquid closed this Aug 21, 2016
@aquid aquid mentioned this pull request Aug 21, 2016
@aquid

aquid commented Aug 21, 2016

Copy link
Copy Markdown
Contributor Author

@bajtos Updated the PR with new commits. Since I had some rebasing issues, a new PR has been generated( #235 ).

Please review it and let me know.
cc @pulkitsinghal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants