This repository was archived by the owner on Apr 20, 2026. It is now read-only.
Repository navigation
Add some issue & label endpoints #73
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
891c945
Add some issue & label endpoints
GriffinCodes 258fe18
Support multiple assignees, serialize users and labels correctly
GriffinCodes 983dd4b
Reorder imports
GriffinCodes a4e483b
Match style
GriffinCodes 3b77be8
Add assignee field back, use @JsonInclude to control
GriffinCodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/main/java/com/spotify/github/jackson/LabelSerializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /*- | ||
| * -\-\- | ||
| * github-api | ||
| * -- | ||
| * Copyright (C) 2016 - 2020 Spotify AB | ||
| * -- | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * -/-/- | ||
| */ | ||
|
|
||
| package com.spotify.github.jackson; | ||
|
|
||
| import static java.util.Objects.isNull; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonGenerator; | ||
| import com.fasterxml.jackson.databind.SerializerProvider; | ||
| import com.fasterxml.jackson.databind.ser.std.StdSerializer; | ||
| import com.spotify.github.v3.issues.Label; | ||
| import java.io.IOException; | ||
|
|
||
| class LabelSerializer extends StdSerializer<Label> { | ||
|
|
||
| static final LabelSerializer INSTANCE = new LabelSerializer(); | ||
|
|
||
| private LabelSerializer() { | ||
| super(Label.class); | ||
| } | ||
|
|
||
| @Override | ||
| public void serialize(final Label value, final JsonGenerator gen, final SerializerProvider serializers) | ||
| throws IOException { | ||
| if (isNull(value)) { | ||
| gen.writeNull(); | ||
| } else { | ||
| serializers.defaultSerializeValue(value.name(), gen); | ||
| } | ||
| } | ||
| } | ||
48 changes: 48 additions & 0 deletions
48
src/main/java/com/spotify/github/jackson/UserSerializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /*- | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This serializer seems like it could be replaced by Jackson annotations too - thoughts? |
||
| * -\-\- | ||
| * github-api | ||
| * -- | ||
| * Copyright (C) 2016 - 2020 Spotify AB | ||
| * -- | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * -/-/- | ||
| */ | ||
|
|
||
| package com.spotify.github.jackson; | ||
|
|
||
| import static java.util.Objects.isNull; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonGenerator; | ||
| import com.fasterxml.jackson.databind.SerializerProvider; | ||
| import com.fasterxml.jackson.databind.ser.std.StdSerializer; | ||
| import com.spotify.github.v3.User; | ||
| import java.io.IOException; | ||
|
|
||
| class UserSerializer extends StdSerializer<User> { | ||
|
|
||
| static final UserSerializer INSTANCE = new UserSerializer(); | ||
|
|
||
| private UserSerializer() { | ||
| super(User.class); | ||
| } | ||
|
|
||
| @Override | ||
| public void serialize(final User value, final JsonGenerator gen, final SerializerProvider serializers) | ||
| throws IOException { | ||
| if (isNull(value)) { | ||
| gen.writeNull(); | ||
| } else { | ||
| serializers.defaultSerializeValue(value.login(), gen); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This serializer seems like it could be replaced by Jackson annotations too - thoughts?