Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Add some issue & label endpoints - #73

Closed
GriffinCodes wants to merge 5 commits into
spotify:masterfrom
ProjectEdenGG:master
Closed

GriffinCodes wants to merge 5 commits into
spotify:masterfrom
ProjectEdenGG:master

Conversation

@GriffinCodes

@GriffinCodes GriffinCodes commented Aug 28, 2021 •

Copy link
Copy Markdown
Contributor
  • Add some issue & label endpoints
  • Support multiple issue assignees
  • Serialize users and labels correctly

Just some work I did for my discord bot

Some questions:

  • I added the Label & User serializers, but if someone ever wants to create/update one of those objects, it will use that serializer and not send the proper payload. Should all fields of that type be annotated with @JsonSerializer(using = <Type>Serializer.class), or is there another way I should be doing it?
  • The use of Optional vs @Nullable seems to be arbitrary; is there a pattern I'm not seeing?

Feedback welcome

Closes #62

Comment thread src/main/java/com/spotify/github/v3/issues/Issue.java
Comment thread src/main/java/com/spotify/github/v3/issues/Issue.java

@barbatron barbatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note on the assignee/assignees . I don't feel strongly about it but am wary of breaking changes. PTAL @GriffinCodes

@GriffinCodes

Copy link
Copy Markdown
Contributor Author

Just a note on the assignee/assignees . I don't feel strongly about it but am wary of breaking changes. PTAL @GriffinCodes

Great idea, made the change and it behaves correctly. Still learning all the features Jackson :)

@GriffinCodes

Copy link
Copy Markdown
Contributor Author

Apologies for the force push, I removed the commit that changed the version in the pom.xml

@@ -0,0 +1,48 @@
/*-

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This serializer seems like it could be replaced by Jackson annotations too - thoughts?

@@ -0,0 +1,48 @@
/*-

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This serializer seems like it could be replaced by Jackson annotations too - thoughts?

@ebk45

ebk45 commented Dec 22, 2023

Copy link
Copy Markdown
Contributor

Hi @GriffinCodes.

We apologise for taking so long to get eyes on this PR, we haven't been able to maintain this library to the standard we would have liked to but this will be changing in the new year. If you could please get this rebased and we'll be prioritising all open PRs ready for review.

Thanks!

Ellie

@ebk45

ebk45 commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Hello,

As this PR is now stale and we've not had any new activity on it, we've decided to close it so we can keep track of active/more recent changes. We will leave the branch untouched in case you would like to reopen and rebase.

Thanks!

Ellie

@ebk45 ebk45 closed this Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IssueClient has nothing to do with issues.

3 participants